Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
DOC: remove redundant gridspec from example#29667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
timhoffm approved these changesFeb 22, 2025
c9402f3 intomatplotlib:main 21 checks passed
Uh oh!
There was an error while loading.Please reload this page.
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestFeb 22, 2025
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestFeb 22, 2025
Thanks@timhoffm! 🚀 |
Note as a follow up: we really should not be using gridspec at all in examples. |
rcomer added a commit that referenced this pull requestFeb 22, 2025
…667-on-v3.10.xBackport PR#29667 on branch v3.10.x (DOC: remove redundant gridspec from example)
timhoffm added a commit that referenced this pull requestFeb 22, 2025
…667-on-v3.10.0-docBackport PR#29667 on branch v3.10.0-doc (DOC: remove redundant gridspec from example)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Since this example uses constrained layout, the 75% modification on the gridspec has no effect. We can therefore simplify this axes creation. (I have a use-case where constrained layout needs to run more times to fit everything properly. I saw this example and thought maybe using the 75% approach would help the constrained layout algorithm by starting closer to where it needs to go, but it made no difference to my use-case either).
Also switched out
set(aspect=forset_aspect(following guidance at#28693 (comment).PR checklist