Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
DOC: Add docstrings to matplotlib.cbook.GrouperView#29617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
LGTM, but please fix the linting errors. |
The linting problem is that the original code was also not conforming (not sure why this is not flagged). It should be sufficient to introduce empty lines before the modified methods. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Sorry if our comments have not been clear.
lib/matplotlib/cbook.py Outdated
| """ | ||
| Return whether *a* and *b* are members of the same set. | ||
| """ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This change is not necessary, in fact the original one conforms to our stylehttps://matplotlib.org/devdocs/devel/document.html#quote-positions. Please revert.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
lib/matplotlib/cbook.py Outdated
| """ | ||
| Remove *a* from the grouper, doing nothing if it is not there. | ||
| """ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
As above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
f94fce6 intomatplotlib:mainUh oh!
There was an error while loading.Please reload this page.
Thanks@star1327p and congratulations on your first contribution to Matplotlib! 🎉 |
…ew (#29627)Co-authored-by: Christine P. Chai <star1327p@gmail.com>
* DOC: Add docstrings to matplotlib.cbook.GrouperView* DOC: Fixed linting errors in cbook.py* Update cbook.pyCo-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>* Update cbook.pyCo-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>* Revert unnecessary changes* Removed unnecessary whitespace---------Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
PR summary
Add docstrings to matplotlib.cbook.GrouperView
PR checklist