Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Correct doc for axvline arg x which sets x not y#29607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join uson gitter for real-time discussion.
For details on testing, writing docs, and our review process, please seethe developer guide
We strive to be a welcoming and open project. Please follow ourCode of Conduct.
8465b0f
intomatplotlib:mainUh oh!
There was an error while loading.Please reload this page.
Thanks@gdmcbain! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again. @meeseeksdev backport to v3.10.x |
…607-on-v3.10.xBackport PR#29607 on branch v3.10.x (Correct doc for axvline arg x which sets x not y)
…607-on-v3.10.0-docBackport PR#29607 on branch v3.10.0-doc (Correct doc for axvline arg x which sets x not y)
As reported in the issue which thiscloses#29606 , the docstring for the argument x of
axvline
says that it sets y, but really it sets x. Perhaps this was a copy'n'paste error fromaxhline
? Where the first argument is y which does set y.This commit simply emends the doc from y to x to reflect the behaviour.
PR checklist