Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

DOC: Recommend constrained_layout over tight_layout#29584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
rcomer merged 3 commits intomatplotlib:mainfromtimhoffm:doc-layout
Feb 28, 2025

Conversation

timhoffm
Copy link
Member

Closes#17339 by addressing the remaining open issue#17339 (comment).

@github-actionsgithub-actionsbot added topic: geometry managerLayoutEngine, Constrained layout, Tight layout Documentation: user guidefiles in galleries/users_explain or doc/users labelsFeb 6, 2025
@timhoffmtimhoffm added this to thev3.10.1 milestoneFeb 6, 2025
@timhoffm
Copy link
MemberAuthor

Likely yes.

Can we go as far as discouragingtight_layout?

@rcomer
Copy link
Member

According to the User Guide menu, it is already mildly discouraged

image

@timhoffmtimhoffm added the status: needs comment/discussionneeds consensus on next step labelFeb 14, 2025
@ksundenksunden modified the milestones:v3.10.1,v3.10.2Feb 21, 2025
Co-authored-by: Mecanerd <joshdonath23@hotmail.com>
@jklymak
Copy link
Member

Well, I'd merge, but merging is blocked by the bot. Which is pretty annoying to be honest. Why do we need a bot to tell us whether we are allowed to merge or not?

@timhoffmtimhoffm removed the status: needs comment/discussionneeds consensus on next step labelFeb 27, 2025
@timhoffm
Copy link
MemberAuthor

We block merging if the label „needs comment/discussion“ is set. IMHO that makes sense because it prevents premature merging when there are still to be discussed aspects.

I had set this mover the question whether tight-layout should be formally discouraged. But that‘s also something we can discuss later/separately. My focus in this PR is to guide users by stating preference between tight-layout and constrained-layout. Therefore, I’ve removed the label.

Co-authored-by: Ruth Comer <10599679+rcomer@users.noreply.github.com>
@rcomerrcomer merged commit293eff8 intomatplotlib:mainFeb 28, 2025
37 of 40 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestFeb 28, 2025
@timhoffmtimhoffm deleted the doc-layout branchFebruary 28, 2025 13:50
rcomer added a commit that referenced this pull requestFeb 28, 2025
…584-on-v3.10.xBackport PR#29584 on branch v3.10.x (DOC: Recommend constrained_layout over tight_layout)
@ksundenksunden mentioned this pull requestMay 9, 2025
5 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@rcomerrcomerrcomer left review comments

@MecanerdMecanerdMecanerd left review comments

@tacaswelltacaswelltacaswell approved these changes

@jklymakjklymakjklymak approved these changes

Assignees
No one assigned
Labels
Documentation: user guidefiles in galleries/users_explain or doc/userstopic: geometry managerLayoutEngine, Constrained layout, Tight layout
Projects
None yet
Milestone
v3.10.3
Development

Successfully merging this pull request may close these issues.

Clarify that constrained_layout and tight_layout conflict with each other
6 participants
@timhoffm@rcomer@jklymak@tacaswell@Mecanerd@ksunden
[8]ページ先頭
©2009-2025 Movatter.jp