Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
DOC: add color sequences reference example#29563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I like the style.
I am in two minds whether to add a second plot with a newly registered color sequence or to leave this as a purely reference example of what is available by default.
You can add a sentence that users can register their own sequences as well and point toregister
. IMHO an example is not too helpful here. The concept "register -> you can query it by name" is straigt forward. The plot itself will not be helpful as you cannot visualize "there's a new element in the registry". That can only be inferred from the associated example code. But as said, the concept is so simple that any example is dilluting the message because of the additional visualization code.
Uh oh!
There was an error while loading.Please reload this page.
Did there used to be a Dark1? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Minor style suggestions.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Take or leave the suggestions.
dd8dbca
intomatplotlib:mainUh oh!
There was an error while loading.Please reload this page.
…563-on-v3.10.xBackport PR#29563 on branch v3.10.x (DOC: add color sequences reference example)
Uh oh!
There was an error while loading.Please reload this page.
PR summary
Introducing the Matplotlib Abacus!
I did not know that the color sequence registry was a thing. Once I did know, the next thing I wanted to know was what sequences are available. This PR adds an example showing all the built in sequences, analogous to theColormaps reference andList of Named Colors.
I am in two minds whether to add a second plot with a newly registered color sequence or to leave this as a purely reference example of what is available by default.
PR checklist