Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

DOC: add color sequences reference example#29563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
timhoffm merged 1 commit intomatplotlib:mainfromrcomer:doc-color-sequences
Feb 2, 2025

Conversation

rcomer
Copy link
Member

@rcomerrcomer commentedFeb 1, 2025
edited
Loading

PR summary

Introducing the Matplotlib Abacus!

image

I did not know that the color sequence registry was a thing. Once I did know, the next thing I wanted to know was what sequences are available. This PR adds an example showing all the built in sequences, analogous to theColormaps reference andList of Named Colors.

I am in two minds whether to add a second plot with a newly registered color sequence or to leave this as a purely reference example of what is available by default.

PR checklist

scottshambaugh reacted with hooray emoji
@rcomer
Copy link
MemberAuthor

New example

Copy link
Member

@timhoffmtimhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I like the style.

I am in two minds whether to add a second plot with a newly registered color sequence or to leave this as a purely reference example of what is available by default.

You can add a sentence that users can register their own sequences as well and point toregister. IMHO an example is not too helpful here. The concept "register -> you can query it by name" is straigt forward. The plot itself will not be helpful as you cannot visualize "there's a new element in the registry". That can only be inferred from the associated example code. But as said, the concept is so simple that any example is dilluting the message because of the additional visualization code.

rcomer reacted with thumbs up emoji
@rcomer
Copy link
MemberAuthor

Did there used to be a Dark1?

@rcomer
Copy link
MemberAuthor

Updated new example

Copy link
Member

@timhoffmtimhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Minor style suggestions.

Copy link
Member

@timhoffmtimhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Take or leave the suggestions.

@timhoffmtimhoffm added this to thev3.10.1 milestoneFeb 2, 2025
@timhoffmtimhoffm merged commitdd8dbca intomatplotlib:mainFeb 2, 2025
35 of 36 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestFeb 2, 2025
@rcomerrcomer deleted the doc-color-sequences branchFebruary 2, 2025 16:51
timhoffm added a commit that referenced this pull requestFeb 2, 2025
…563-on-v3.10.xBackport PR#29563 on branch v3.10.x (DOC: add color sequences reference example)
@ksundenksunden mentioned this pull requestMar 3, 2025
5 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.10.1
Development

Successfully merging this pull request may close these issues.

2 participants
@rcomer@timhoffm

[8]ページ先頭

©2009-2025 Movatter.jp