Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Bug Fix: Normalize kwargs for Histogram#29552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
QuLogic merged 3 commits intomatplotlib:mainfromTheSkyentist:hist-kwargs
Feb 14, 2025
Merged

Bug Fix: Normalize kwargs for Histogram#29552

QuLogic merged 3 commits intomatplotlib:mainfromTheSkyentist:hist-kwargs
Feb 14, 2025

Conversation

TheSkyentist
Copy link
Contributor

@TheSkyentistTheSkyentist commentedJan 30, 2025•
edited
Loading

PR summary

Closes#28884 by normalizing kwargs for hist. The behavior of shortened options, such as ls and ec, now behave as expected.

pyplot.hist([1,2,3,4,5],bins=5,histtype='step',ls=':')pyplot.savefig('test.pdf')

now producestest.pdf

First brought to my attention by@ecrohr

PR checklist

  • new and changed code istested

hirohira9119 reacted with thumbs up emoji
Copy link

@github-actionsgithub-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join uson gitter for real-time discussion.

For details on testing, writing docs, and our review process, please seethe developer guide

We strive to be a welcoming and open project. Please follow ourCode of Conduct.

@scottshambaugh
Copy link
Contributor

I believe this is the issue this would close?#28884

@TheSkyentist
Copy link
ContributorAuthor

Good catch! I made this draft while writing the issue. I’ll update the info.

@TheSkyentistTheSkyentist marked this pull request as ready for reviewJanuary 31, 2025 09:21
@QuLogic
Copy link
Member

Does this fully close#28884? It doesn't add plurals, and I think we didn't yet make a decision in#28884 on whether we evenwanted to add plurals.

@timhoffm
Copy link
Member

You are right and that's ok. The issue itself is not decided whether we actually want plurals. This implements the obvious and uncontroversial part of the issue.

Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
@QuLogicQuLogic added this to thev3.11.0 milestoneFeb 14, 2025
@QuLogicQuLogic merged commit067b77c intomatplotlib:mainFeb 14, 2025
41 checks passed
@QuLogic
Copy link
Member

Thanks@TheSkyentist! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again.

TheSkyentist reacted with heart emoji

@TheSkyentistTheSkyentist deleted the hist-kwargs branchFebruary 14, 2025 13:04
prafulgulani pushed a commit to prafulgulani/matplotlib that referenced this pull requestFeb 22, 2025
* Normalize kwargs for hist* Avoid shadowing the builtin first!Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
@cgahrcgahr mentioned this pull requestMar 4, 2025
@timhoffm
Copy link
Member

@meeseeksdev backport to v3.10.x

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestMar 26, 2025
@timhoffmtimhoffm modified the milestones:v3.11.0,v3.10.2Mar 26, 2025
QuLogic added a commit that referenced this pull requestMar 27, 2025
…552-on-v3.10.xBackport PR#29552 on branch v3.10.x (Bug Fix: Normalize kwargs for Histogram)
@ksundenksunden mentioned this pull requestMay 9, 2025
5 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments

@QuLogicQuLogicQuLogic approved these changes

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.10.3
Development

Successfully merging this pull request may close these issues.

[ENH]: Expandhist() signature to support aliases and plural kwargs
4 participants
@TheSkyentist@scottshambaugh@QuLogic@timhoffm
[8]ページ先頭
©2009-2025 Movatter.jp