Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

DOC: correctly specify return type offigaspect#29545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
QuLogic merged 2 commits intomatplotlib:mainfromDerWeh:doc-figaspect
Apr 3, 2025

Conversation

DerWeh
Copy link
Contributor

PR summary

The docstring and type hint ofplt.figaspect suggest that it returns a tuple of floats, while in fact it returns a NumPy array. The docstring is clarified and the type hint fixed.

This was one of the issues mentioned in the issue#29540. While this PR addresses the documentation it does not fix the issue.

PR checklist

@DerWeh
Copy link
ContributorAuthor

PR should be good to merge now.

@DerWehDerWeh requested a review fromtimhoffmFebruary 5, 2025 20:01
@rcomerrcomer linked an issueFeb 13, 2025 that may beclosed by this pull request
@DerWehDerWeh requested a review fromrcomerFebruary 16, 2025 20:36
@DerWeh
Copy link
ContributorAuthor

@tacaswell@timhoffm@rcomer Is there anything to be done to get this PR merged? As far as I can see, there are no more problems.

@timhoffm
Copy link
Member

This needs a second review by a core developer, unfortunately review time is scarce.

@QuLogicQuLogic merged commitc70cd78 intomatplotlib:mainApr 3, 2025
45 checks passed
@QuLogicQuLogic added this to thev3.10.2 milestoneApr 3, 2025
@QuLogic
Copy link
Member

@meeseeksdev backport to v3.10.x

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestApr 3, 2025
QuLogic added a commit that referenced this pull requestApr 3, 2025
…545-on-v3.10.xBackport PR#29545 on branch v3.10.x (DOC: correctly specify return type of `figaspect`)
@DerWehDerWeh deleted the doc-figaspect branchApril 3, 2025 15:42
@ksundenksunden mentioned this pull requestMay 9, 2025
5 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell left review comments

@QuLogicQuLogicQuLogic approved these changes

@timhoffmtimhoffmtimhoffm approved these changes

@rcomerrcomerAwaiting requested review from rcomer

Assignees
No one assigned
Projects
None yet
Milestone
v3.10.3
Development

Successfully merging this pull request may close these issues.

[Bug]: matshow(..., fignum=...) broken
5 participants
@DerWeh@timhoffm@QuLogic@tacaswell@rcomer
[8]ページ先頭
©2009-2025 Movatter.jp