Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
MNT: Deprecate other capitalization than "None" in matplotlibrc#29529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
61a0829 to93e01c8CompareI appear to have infiltrated your commit somehow 😕 |
Uh oh!
There was an error while loading.Please reload this page.
Not sure how this happend 😆. I've possibly messed up with --amend when creating the PR, but don't remember. If it's ok for you, I would not bother. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
+- fixing the flake error
It seems like you'll have to update to fix the linting anyway, so to fix, use |
The `*_or_None` validators have accepted any capitalization of thestring "none" as input. This is overly permissive andwill likely lead to conflicts in the future because we cannotdistinguish between resolving to `None` and `"none"` which may be needfor some parameters in the future.Inspired bymatplotlib#29481.
9225687 to5c8c9b5Compare743a005 intomatplotlib:mainUh oh!
There was an error while loading.Please reload this page.
The
*_or_Nonevalidators have accepted any capitalization of the string "none" as input. This is overly permissive and will likely lead to conflicts in the future because we cannot distinguish between resolving toNoneand"none"which may be need for some parameters in the future.Inspired by#29481.