Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
BUG : turned clipping off on pie chart components#2952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Could you maybe explain why this is better than just adjust the hardcoded limits by a small amount? |
I think this is better than adjusting the limits because now the patches and the text match clipping behavior. It would be better to control this via kwarg (not hard coded) for both the text and the wedges. I will take care of that when I rebase. |
@Tillsten Changed to leveraging the newly added *props dicts. |
Could you also link the PR where the dict was added? Still one question left (see commit coment). If the answer is no, LGTM. Thanks again for you work! |
The dicts were added in#2923 |
You are right, it copys the props, so LGTM from me. |
- set default value of `clip_on` in *prop dicts -closesmatplotlib#2518
BUG : turned clipping off on pie chart components
closes#2518
This should probably get a test,https://stackoverflow.com/questions/19347453/matplotlib-savefig-trims-the-graph should be a good base.