Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

TST: Increase tolerance on more arches#29518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tacaswell merged 1 commit intomatplotlib:mainfromQuLogic:arch-tolerance
Jan 31, 2025

Conversation

QuLogic
Copy link
Member

PR summary

Not sure why this didn't hit Fedora when 3.10.0 was initially built, but it is now during the F42 Mass Rebuild.

These tests are already covered byarm64-specific tolerances (aka Apple Silicon), and while one or two won't need it, I've changed all of these.

Additionally, instead of listing every single architecture, just increase the tolerance on non-x86_64. Also, make a few tweaks to existing conditions to make these all consistent.

PR checklist

@QuLogicQuLogic added this to thev3.10.1 milestoneJan 25, 2025
@QuLogic
Copy link
MemberAuthor

This successfully built everywhere:https://koji.fedoraproject.org/koji/taskinfo?taskID=128446738

Not sure why this didn't hit Fedora when 3.10.0 was initially built, butit is now during the F42 Mass Rebuild.These tests are already covered by `arm64`-specific tolerances (akaApple Silicon), and while one or two won't need it, I've changed all ofthese.Additionally, instead of listing every single architecture, justincrease the tolerance on non-x86_64. Also, make a few tweaks toexisting conditions to make these all consistent.
@tacaswelltacaswell merged commit8c3f4ec intomatplotlib:mainJan 31, 2025
41 checks passed
@lumberbot-appLumberbot (App)
Copy link

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v3.10.xgit pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 8c3f4eca28ddc7e47675cfeafe38ca6c85853313
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #29518: TST: Increase tolerance on more arches'
  1. Push to a named branch:
git push YOURFORK v3.10.x:auto-backport-of-pr-29518-on-v3.10.x
  1. Create a PR against branch v3.10.x, I would have named this PR:

"Backport PR#29518 on branch v3.10.x (TST: Increase tolerance on more arches)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove theStill Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free tosuggest an improvement.

tacaswell added a commit to tacaswell/matplotlib that referenced this pull requestJan 31, 2025
Merge pull requestmatplotlib#29518 from QuLogic/arch-toleranceTST: Increase tolerance on more arches(cherry picked from commit8c3f4ec)
@tacaswell
Copy link
Member

Did the manual backport:#29557

@QuLogicQuLogic deleted the arch-tolerance branchJanuary 31, 2025 21:29
QuLogic added a commit that referenced this pull requestFeb 1, 2025
…-v3.10.xBackport PR#29518: TST: Increase tolerance on more arches
@ksundenksunden mentioned this pull requestMar 3, 2025
5 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.10.1
Development

Successfully merging this pull request may close these issues.

3 participants
@QuLogic@tacaswell@timhoffm
[8]ページ先頭
©2009-2025 Movatter.jp