Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

ci: Add an ARM Linux test workflow#29477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
timhoffm merged 1 commit intomatplotlib:mainfromQuLogic:arm-ci
Jan 18, 2025
Merged

Conversation

QuLogic
Copy link
Member

@QuLogicQuLogic commentedJan 17, 2025•
edited
Loading

PR summary

Like the macOS jobs are mixed between Intel and ARM, this changes one of the Linux jobs to use ARM.

We'll see if we need to make any changes as in#24597 after the build is complete.

PR checklist

@QuLogicQuLogic added the CI: testingCI configuration and testing labelJan 17, 2025
@QuLogic
Copy link
MemberAuthor

I should probably skip some backends though; it seems PyQt5 doesnt have a wheel and is just stuck.

echo 'PyQt5 is not available'
# PyQt5 does not have any wheels for ARM on Linux.
if [[ "${{ matrix.os }}" != 'ubuntu-20.04-arm' ]]; then
python -mpip install --upgrade pyqt5${{ matrix.pyqt5-ver }} &&
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
python -mpip install --upgrade pyqt5${{ matrix.pyqt5-ver }} &&
python -mpip install --upgrade pyqt5${{ matrix.pyqt5-ver }}--only-binary pyqt5&&

The latest CI job seems like it is trying to build pyqt5 from an sdist still.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Ah, I messed up the condition, but I've added this as well.

@QuLogic
Copy link
MemberAuthor

There are two failures:

  • test_preset_clip_paths, which we already add a tolerance onarm64 (aka Apple Silicon), so I've addedaarch64 there as well.
  • test_pcolormesh_alpha, which we don't have any non-zero tolerance on. The diff for this one is:
    pcolormesh_alpha-failed-diff
    I don't really know why this one is different, but it seems small enough to just increase.

Like the macOS jobs are mixed between Intel and ARM, this changes one ofthe Linux jobs to use ARM.
@timhoffmtimhoffm merged commit3fb9c09 intomatplotlib:mainJan 18, 2025
39 checks passed
@QuLogicQuLogic deleted the arm-ci branchJanuary 18, 2025 02:17
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell approved these changes

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Labels
CI: testingCI configuration and testing
Projects
None yet
Milestone
v3.11.0
Development

Successfully merging this pull request may close these issues.

3 participants
@QuLogic@tacaswell@timhoffm
[8]ページ先頭
©2009-2025 Movatter.jp