Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

CI: add py312 and py313 on windows on azure to test matrix#29473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
timhoffm merged 2 commits intomatplotlib:mainfromtacaswell:ci/azure_py313
Jan 20, 2025

Conversation

tacaswell
Copy link
Member

Noted will looking at#29472 that we are only testing py310 and py311 on either windows platform.

@tacaswelltacaswell added this to thev3.11.0 milestoneJan 15, 2025
@QuLogic
Copy link
Member

A change like this should fix the test:

diff --git a/lib/matplotlib/tests/test_animation.py b/lib/matplotlib/tests/test_animation.pyindex 6a9f31733f..a2b35f802c 100644--- a/lib/matplotlib/tests/test_animation.py+++ b/lib/matplotlib/tests/test_animation.py@@ -520,7 +520,7 @@ def test_disable_cache_warning(anim):  def test_movie_writer_invalid_path(anim):     if sys.platform == "win32":-        match_str = r"\[WinError 3] .*'\\\\foo\\\\bar\\\\aardvark'"+        match_str = r"\[WinError 3] .*\\\\foo\\\\bar\\\\aardvark'"     else:         match_str = r"\[Errno 2] .*'/foo"     with pytest.raises(FileNotFoundError, match=match_str):

@tacaswell
Copy link
MemberAuthor

Do we understand what changed in py313? From looking at the failing string it looks like Python now includes the full path with a drive? Strongly suspect it ispython/cpython#119826 making an internalabspath call more correct.

@QuLogic
Copy link
Member

That seems related from the changelog, but it was backported to 3.12.8, which didn't fail that first time.

@tacaswell
Copy link
MemberAuthor

Interesting. However, given that this is the text of an error message (and I think including the drive letter is better) I don't think it is worth spending too much time to track it down.

@QuLogic
Copy link
Member

Could bepython/cpython#126780 as the input is a drive-relative path on Windows, and this wasn't backported to 3.12.

@timhoffmtimhoffm merged commit06548d2 intomatplotlib:mainJan 20, 2025
41 checks passed
@tacaswelltacaswell deleted the ci/azure_py313 branchJanuary 21, 2025 12:41
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@QuLogicQuLogicQuLogic approved these changes

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.11.0
Development

Successfully merging this pull request may close these issues.

3 participants
@tacaswell@QuLogic@timhoffm

[8]ページ先頭

©2009-2025 Movatter.jp