Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
MNT: Separate property cycle handling from _process_plot_var_args#29469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
By encapsulating the cycling into a dedicated class, we prepare formaking cycling sharable between multiple _process_plot_var_args instances,which is the prerequisite for unifying the separate cyclers for lines andpatches (matplotlib#29468) and sharing cyclers between multiple Axes (matplotlib#19479).
| def _setdefaults(self, defaults, kw): | ||
| @staticmethod |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is not strictly related, but noticed that_setdefaults does not depend on the class, so making that explicit viastaticmethod as an improvement on the side.
cvanelteren commentedJan 25, 2025
Hi, just wanted to chip in that we are facing similar issues that it is a bit opague how the cycling is handled. In our case we would also need a |
Thanks for the feedback. This PR is an internal refactoring and since we currently don’t need that function. I won’t add it to the PR. After all, this is all internal for now and we reserve the right to change everything. Even if I would add the function you could not rely that it will be available and have a defined API. That said, this is part of a larger plan to make cycling more flexible. I plan to make the cycle in the Axes accessible as public API, which also includes the ability to get the next element. |
cvanelteren commentedJan 25, 2025
Ok thanks for clarifying. Then I will proceed with our internal cycling for now. |
By encapsulating the cycling into a dedicated class, we prepare for making cycling sharable between multiple _process_plot_var_args instances, which is the prerequisite for unifying the separate cyclers for lines and patches (#29468) and sharing cyclers between multiple Axes (#19479).