Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Fix dead links in dev workflow docs#29463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
You seem to also have the commits from#29433 in this PR. While they are identical, the marge would go through, but please rebase so that it's clear these commits don't have anything to do with this PR.
Uh oh!
There was an error while loading.Please reload this page.
On a side-note, please don't name PRs like |
I've tried to resolve the issue, but I guess the checks still didn't pass. I am open to all your suggestions, please guide me where I am doing things wrong since I am in my learning process :) |
To fix the PR cleanliness check, you can squash the commits into one with aninteractive rebase. |
Thankyou@rcomer for the help :) |
I think you can also use interactive rebase to drop the "attach_note" commit. For future PRs, you shouldcreate a separate feature branch, and then you don't get this problem. |
Sure@rcomer I'll keep that in mind. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Don't accept my review w/o first dropping the unrelated commit, but the articlethe
is missing
doc/devel/development_workflow.rst Outdated
@@ -138,13 +138,10 @@ The editing workflow | |||
Note the ``-am`` options to ``commit``. The ``m`` flag signals that you are | |||
going to type a message on the command line. The ``a`` flag stages every | |||
file that has been modified, except files listed in ``.gitignore``. For more | |||
information, see `why the -a flag?`_ and the | |||
`git commit <https://git-scm.com/docs/git-commit>`_ manual page. | |||
information, see `git commit <https://git-scm.com/docs/git-commit>`_ manual page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
information, see `git commit<https://git-scm.com/docs/git-commit>`_ manual page. | |
information, seethe`git commit<https://git-scm.com/docs/git-commit>`_ manual page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
okay I'll fix it
- Removed unnecessary sentence in the development workflow.- Fixed broken link in `development_workflow.rst`.
2f51249
intomatplotlib:mainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
PR summary
Closes#29305.
PR checklist