Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.1k
Fixes #29428 : Remove erroneous statement in multipage PDF example#29433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join uson gitter for real-time discussion.
For details on testing, writing docs, and our review process, please seethe developer guide
We strive to be a welcoming and open project. Please follow ourCode of Conduct.
jaskij commentedJan 9, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Feels like you went a little over the top being explicit, but yes, this absolutely works. |
tacaswell commentedJan 9, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Thank you for your work on this. The doc failures are real. In rst single back-ticks are "please make this a cross reference".
|
rcomer commentedJan 9, 2025
Does this also need updating following the discussion with@anntzer on the issue? |
tacaswell commentedJan 9, 2025
Yes! |
Khushikela29 commentedJan 10, 2025
@tacaswell am I suppose to do changes? or this PR works ? |
tacaswell commentedJan 10, 2025
Per the discussion in#29428 my understanding is we don't need to clarify this note, we can just remove it. Once that change is made, the docs need to build cleanly (which currently they are not). |
Khushikela29 commentedJan 10, 2025
okay, I'll remove it |
Khushikela29 commentedJan 11, 2025
I've removed the sentence in the doc, if you need further changes you can tell me |
685ea2b intomatplotlib:mainUh oh!
There was an error while loading.Please reload this page.
rcomer commentedJan 11, 2025
Thanks@Khushikela29 and congratulations on you first Matplotlib PR! 🎉 |
Khushikela29 commentedJan 11, 2025
Thankyou !! How can I contribute more to the repository can you guide me ? |
rcomer commentedJan 11, 2025
@Khushikela29 please have a look at our Contributors’ Guide here: |
Uh oh!
There was an error while loading.Please reload this page.
PR summary
PR checklist