Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
ft2font: Split named instance count from style flags#29431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
These are unrelated, and breaks the enum since the instance count isoutside the defined flags.
anntzer approved these changesJan 8, 2025
a61e118 intomatplotlib:main 44 of 47 checks passed
Uh oh!
There was an error while loading.Please reload this page.
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestJan 8, 2025
oscargus added a commit that referenced this pull requestJan 8, 2025
…431-on-v3.10.xBackport PR#29431 on branch v3.10.x (ft2font: Split named instance count from style flags)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
Documentation: examplesfiles in galleries/examples Release criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. topic: text/fonts
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
These are unrelated, and it breaks the enum since the instance count is outside the defined flags.
Note, tests are always 0 since we don't ship variable fonts, but I did test the example on Inter Variable and got 9 as expected.
It's a bit of an API change, but I think small enough to warrant backporting directly instead of the other options in#29396.
Fixes#29396
PR checklist