Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

#2150 Updating patch limits if either width or height is non zero: Issue 2150#2942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
sfroid wants to merge4 commits intomatplotlib:masterfromsfroid:issue_2150

Conversation

sfroid
Copy link
Contributor

Previously, we would not update the patch limits, if either width or height of the patch were 0.

Now, if either width is non zero (vertical bar graph with zero entries) or height is non zero (horizontal bar graphs), the patch limits will be updated. If both width and height are zero, the patch will be ignored.

@sfroid
Copy link
ContributorAuthor

@tacaswell
Thomas, I have created the pull request to get your feedback. Do you think this is the correct and complete solution for#2150 ?
I have tested horizontal and vertical bar graphs with leading and trailing zeros and it gives the correct and expected output.

If so, I will add image tests and polish it for merging.

@tacaswell
Copy link
Member

It seems reasonable to me and all of the tests pass, however I am worried about un-intended consequences.@efiring or@mdboom should sign off on this on.

If there is not some compelling reason that this logicmust be anor, this is much better than the proposed solutions of passing extra hints to the auto-limit code.

One of the fun things about a large code base is you tend to assume things are done some way 'for a reason'.

I am a bit concerned by the 'merge from master' in the history. Our practice is to keep re-basing branches if the conflict with master.

@efiring
Copy link
Member

The comment in update_patch_limits says the rationale for "or" is that otherwise log scaling has problems. I don't know offhand whether this is still the case, and if so, whether there might be a better solution to that problem. Apart from that, the "and" proposed here seems reasonable.

@tacaswell
Copy link
Member

@sfroid This needs to be rebased (conflicts in CHANGELOG).

Did you get a chance to investigate how this interacts withlog?

@tacaswelltacaswell added this to thev1.4.0 milestoneApr 20, 2014
@tacaswell
Copy link
Member

It seems to work fine with log-scaling.

Closing because I merged the non-merge commits on a local machine and pushed to master.

@pelson
Copy link
Member

@tacaswell - I know it adds a small overhead, but would you mind linking to the change if you end up doing it by hand? It just makes it easier to find what has gone on where. Thanks 😄

@tacaswell
Copy link
Member

Sorry about that, I will take care of this next time I am at a real computer.

@tacaswell
Copy link
Member

Merged in899f11d

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging this pull request may close these issues.

4 participants
@sfroid@tacaswell@efiring@pelson

[8]ページ先頭

©2009-2025 Movatter.jp