Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
DOC: Improve log scale example#29407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
timhoffm commentedJan 5, 2025
- Removehttps://matplotlib.org/stable/gallery/scales/semilogx_demo.html It is redundant to the other log scale example.
- Explain that semilogx/semilogy/loglog are shortcuts.
- Tune data/visualization
scottshambaugh commentedJan 7, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Maybe this is nitpicky, but could we have a "plain" semilogy plot next to the semilogx one? I think the base 2 labeling is super useful to include, but it takes some interpretation. It'd be nice to have a semilogy plot that you can see at a glance what's going on, and then the base 2 labeling plot could be kept but moved down. It'd also be nice to have the minor gridlines turned on for one of these plots. |
Indeed a bit nitpicky. 😄 It's a bit the question of how much can you illustrate with an example. Theoriginal example had the base 2 on the loglog plot. I found this very unfortunate because (1) I've never seed double-log plots with different bases. That seems quite exotic. (2) to get that, one had to use I also think that adding minor grids here would be too cluttered. If we want to have all the aspects in, we probably need to structure the example into subsections:
|
However you want to slice it! I think it's definitely an improvement over what's there currently. |
6adabd3
to2c399be
Compare- Removehttps://matplotlib.org/stable/gallery/scales/semilogx_demo.html It is redundant to the other log scale example.- Explain that semilogx/semilogy/loglog are shortcuts.- Tune data/visualization
@scottshambaugh I've reworked the example. There's now one plot with semilogx/semilogy/loglog, also containing minor grids, as that makes it more obvious which directions are logarithmic. I've added separate examples |
I think this looks great, breaking it up into sections was a good move and the exposition helps a lot to interpret what's going on. Good to merge unless you want another reviewer! |
9a834ad
intomatplotlib:mainUh oh!
There was an error while loading.Please reload this page.
…407-on-v3.10.xBackport PR#29407 on branch v3.10.x (DOC: Improve log scale example)
…407-on-v3.10.0-docBackport PR#29407 on branch v3.10.0-doc (DOC: Improve log scale example)