Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Fix 29381 title position#29391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Fix 29381 title position#29391
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…itioning- Add new public method get_title_top() to calculate title position- Implement specialized versions for PolarAxes and GeoAxes- Add tests for different projections- Update _adjust_title_position to use the new methodThis change allows subclasses to customize title positioning byoverriding get_title_top(), fixing the title position issue inpolar plots (matplotlib#29381).
…itioning- Add new public method get_title_top() to calculate title position- Implement specialized versions for PolarAxes and GeoAxes- Add tests for different projections- Update _adjust_title_position to use the new method- Improve documentation and code clarityThis change allows subclasses to customize title positioning byoverriding get_title_top(), fixing the title position issue inpolar plots (matplotlib#29381).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join uson gitter for real-time discussion.
For details on testing, writing docs, and our review process, please seethe developer guide
We strive to be a welcoming and open project. Please follow ourCode of Conduct.
- Fix code style issues- Add test fixtures- Improve documentation- Clean up whitespace and formatting- Fix test stub errors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Hello@aydinomer00, thank you for your interest in improving Matplotlib. I think you are looking to address#29385. My apologies, I made a mistake in that issue. Instead of_adjust_title_position I should have said_update_title_position. This is an already existing method which already has code to calculatetop. The idea was to factor that code into a new method but keep the logic the same.
Cartopy is a separate project and changes for GeoAxes would be added within the Cartopy project in future. We should not add a Cartopy module in Matplotlib.
I also see changes here that are unrelated to the title positioning problem, particularly in the tests. Those should not be made here.
Superseeded by#29382. |
PR summary
PR checklist