Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix title position for polar plots#29382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
scottshambaugh merged 1 commit intomatplotlib:mainfromrcomer:fix-polar-title
Jan 6, 2025

Conversation

rcomer
Copy link
Member

@rcomerrcomer commentedDec 27, 2024•
edited
Loading

PR summary

Fixes#29381 by partially reverting#28300. The problem was as described at#29381 (comment). We could potentially retain most of the performance gain from#28300 by adding a new return option (or two) toget_ticks_position. However, I am nervous about doing that in a micro release and propose to look at it as a follow up for v3.11. Note that this should not much affect the first and last performance gains outlined at#28300 (comment).

PR checklist

timhoffm reacted with thumbs up emoji
@rcomerrcomer added Release criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. topic: polar PR: bugfixPull requests that fix identified bugs labelsDec 27, 2024
@rcomerrcomer added this to thev3.10.1 milestoneDec 27, 2024
@@ -220,6 +220,21 @@ def test_polar_rlabel_position():
ax.tick_params(rotation='auto')


@mpl.style.context('default')
Copy link
MemberAuthor

@rcomerrcomerDec 27, 2024•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This fails in classic mode. However it also fails in classic mode with v3.9.

output

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Could you add an image comparison test that has polar titles? This seems like something we should check visually

rcomer reacted with thumbs up emoji
@scottshambaughscottshambaugh merged commit86f089c intomatplotlib:mainJan 6, 2025
39 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestJan 6, 2025
QuLogic added a commit that referenced this pull requestJan 7, 2025
…382-on-v3.10.xBackport PR#29382 on branch v3.10.x (Fix title position for polar plots)
@rcomerrcomer deleted the fix-polar-title branchJanuary 7, 2025 08:23
@timhoffmtimhoffm mentioned this pull requestJan 24, 2025
5 tasks
@ksundenksunden mentioned this pull requestMar 3, 2025
5 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@timhoffmtimhoffmtimhoffm approved these changes

@scottshambaughscottshambaughscottshambaugh approved these changes

Assignees
No one assigned
Labels
PR: bugfixPull requests that fix identified bugsRelease criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.topic: axes
Projects
None yet
Milestone
v3.10.1
Development

Successfully merging this pull request may close these issues.

[Bug]: title position incorrect for polar plot
3 participants
@rcomer@timhoffm@scottshambaugh
[8]ページ先頭
©2009-2025 Movatter.jp