Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
DOC: Improve NonUniformImage docs#29370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
03517d0
toc6baa0b
ComparePlease see the comment at#29368 (comment). I think we should go further and discourage its use to prevent a maintenance burden of a method that doesn't have much advantage. |
c6baa0b
to1591005
CompareDiscouraging/deprecating is more than I want to invest into this PR. I just realized, that we have not documented what non-uniform actually means and added a quick description. IMHO that's a plus even if we decide to discrouage/deprecate. Discouraging/deprecating needs a dedicated discussion. There are some things to consider:
|
dstansby left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM - one optional suggestion.
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: David Stansby <dstansby@gmail.com>
@dstansby I've accepted your proposal. Please squash-merge. |
033b666
intomatplotlib:mainUh oh!
There was an error while loading.Please reload this page.
…370-on-v3.10.xBackport PR#29370 on branch v3.10.x (DOC: Improve NonUniformImage docs)
No description provided.