Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
FIX: Add version gate to GTK4 calls when necessary#29363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| @@ -37,6 +39,7 @@ class FigureCanvasGTK4(_FigureCanvasGTK, Gtk.DrawingArea): | |||
| def __init__(self, figure=None): | |||
| super().__init__(figure=figure) | |||
| print("GI version", gi.version_info) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| print("GI version", gi.version_info) |
stray debugging print.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks! I guess this confirms I was testing it locally with various gi versions ;) and this did work on both lower and upper
get_current_event() calls within pygobject would cause segfaults. Thiswas fixed in 3.47, so gate the guiEvent information to only accessthat method in versions that don't segfault.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Mypy failure is unrelated (#29362)
"power-cycled" to re-run against current main which should fix the mypy issues. |
cb2d928 intomatplotlib:mainUh oh!
There was an error while loading.Please reload this page.
…363-on-v3.10.xBackport PR#29363 on branch v3.10.x (FIX: Add version gate to GTK4 calls when necessary)
PR summary
get_current_event()calls within pygobject would cause segfaults. This was fixed in 3.47, so gate the guiEvent information to only access that method in versions that don't segfault.closes#29350
PR checklist