Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Type annotation add_subplot for projection="3d"#29341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
timhoffm merged 5 commits intomatplotlib:mainfromstefanv:add_subplots-axes3d
May 2, 2025

Conversation

@stefanv
Copy link
Contributor

This is a proof-of-concept PR to address#29334

Jeitan reacted with thumbs up emoji
@dstansby
Copy link
Member

This looks good to me at a glance - is there still interest in merging this? It's currently marked as draft.

timhoffm reacted with thumbs up emoji

@stefanvstefanv marked this pull request as ready for reviewApril 30, 2025 23:12
@stefanv
Copy link
ContributorAuthor

I'd still like to see this, or something like it, merged!

@stefanvstefanvforce-pushed theadd_subplots-axes3d branch from3b60169 to81f6ba3CompareMay 1, 2025 16:50
frommatplotlib.patchesimportRectangle,Patch
frommatplotlib.textimportText
frommatplotlib.transformsimportAffine2D,Bbox,BboxBase,Transform
ifTYPE_CHECKING:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Actually, this guard is not needed in .pyi files, because they are only used for tyoechecking.

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

OK, removed

@dstansbydstansby requested a review fromtimhoffmMay 2, 2025 18:01
@timhoffmtimhoffm merged commitabda9dd intomatplotlib:mainMay 2, 2025
40 checks passed
@stefanv
Copy link
ContributorAuthor

Thank you!

@galah92
Copy link

Is there a timeline for this to be available in an official release?

btjanaka reacted with thumbs up emoji

GameRoMan added a commit to GameRoMan/matplotlib that referenced this pull requestJul 13, 2025
@ksundenksunden mentioned this pull requestAug 7, 2025
5 tasks
ksunden pushed a commit to ksunden/matplotlib that referenced this pull requestAug 21, 2025
btjanaka added a commit to icaros-usc/pyribs that referenced this pull requestAug 22, 2025
…606)## Description<!-- Provide a brief description of the PR's purpose here. -->Proof of concept for adding type annotations to pyribs. For typechecking, I am currently using [ty](https://docs.astral.sh/ty/) -- itlines up well with Ruff in terms of being really fast. However, ty isnot quite production ready, so support for it in pre-commit and othertools is not quite ready yet (e.g., ALE:dense-analysis/ale#4971). However, I found itmostly sufficient for my purposes.In the future, the goal will be to add type annotations everywhere elsein pyribs.This regex is helpful for catching docstrings that have old types:```grep -r "^ *[a-z_]* (.*):" ribs```## TODO<!-- Notable points that this PR has either accomplished or willaccomplish. -->- [x] Add ty to dev deps- [x] Add ty to pre-commit -- seeastral-sh/ty#269- [x] Skip ty in pre-commit CI- [x] Add ty instructions to docs- [x] Add type annotations in ribs.visualize- [x] Matplotlib imports in ribs.visualize had to be made more specific;see notes on submodules here:astral-sh/ty#445- [x] `plt.axes(projection="3d")` isn't typed for the correct `Axes3D`object, so I had to add some ignores; seematplotlib/matplotlib#29341- [x] Add py.typed and include it in MANIFEST.in## Status- [x] I have read the guidelines in[CONTRIBUTING.md](https://github.com/icaros-usc/pyribs/blob/master/CONTRIBUTING.md)- [x] I have linted and formatted my code with `ruff`- [x] I have tested my code by running `pytest`- [x] I have added a description of my change to the changelog in`HISTORY.md`- [x] This PR is ready to go
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@QuLogicQuLogicQuLogic left review comments

@timhoffmtimhoffmtimhoffm approved these changes

@dstansbydstansbydstansby approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

v3.11.0

Development

Successfully merging this pull request may close these issues.

7 participants

@stefanv@dstansby@galah92@QuLogic@timhoffm@tacaswell@scottshambaugh

[8]ページ先頭

©2009-2025 Movatter.jp