Dec 13, 2024 · Dec 13, 2024 · Dec 13, 2024
diff --git a/lib/matplotlib/lines.py b/lib/matplotlib/lines.py
        return offset, dashes
    scaled_offset = offset * lw
    scaled_dashes = ([x * lw if x is not None else None for x in dashes]
                     if dashes is not None else None)
                     if dashes is not Noneand lw > 0else None)
    return scaled_offset, scaled_dashes


diff --git a/lib/matplotlib/tests/test_collections.py b/lib/matplotlib/tests/test_collections.py
        c.set_linestyle('fuzzy')


 @mpl.style.context('default')
 def test_zero_linewidth_scaling():
    c = Collection()
    c.set_linestyle('dashed')
    c.set_linewidth(0)

    # With a zero linewidth, there can be no pattern
    assert c.get_linestyle() == [(0, None)]


 @mpl.style.context('default')
 def test_capstyle():
    col = mcollections.PathCollection([])
Original file line number	Diff line number	Diff line change
Expand Up		@@ -77,7 +77,7 @@ def _scale_dashes(offset, dashes, lw):
		return offset, dashes
		scaled_offset = offset * lw
		scaled_dashes = ([x * lw if x is not None else None for x in dashes]
		if dashes is not None else None)
		if dashes is not Noneand lw > 0else None)
		return scaled_offset, scaled_dashes


Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -680,6 +680,16 @@ def test_set_wrong_linestyle():
		c.set_linestyle('fuzzy')


		@mpl.style.context('default')
		def test_zero_linewidth_scaling():
		c = Collection()
		c.set_linestyle('dashed')
		c.set_linewidth(0)

		# With a zero linewidth, there can be no pattern
		assert c.get_linestyle() == [(0, None)]
Copy link Member timhoffmDec 13, 2024• edited Loading Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Note that "solid" results in`[('', None)]` instead which I believe is incorrect wrt. to the declared type. We are overall not consistent and clear what`get_linestyle()` means: for`Line2D.get_linestyle()` it is always a str, and if given a dash pattern, the result is "--". for`Patch.get_linestyle()`, we basically get what we put in str or (unscaled) dash pattern; with the exception of normalizing "no style" ' ', '', 'none' to "None" for Collections, we always get a scaled dash pattern. While this fix may be ok as a workaround to fix the original issue (and doesn't make the consisteny worse), we should generally agee upon what`get_linestyle()` means - and a scaled dash pattern would be the last of my choices. rcomer reacted with thumbs up emoji Copy link MemberAuthor rcomerDec 13, 2024• edited Loading Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Actually looking closer, I don't think the legend handler should be getting the scaled pattern - it gets scaled again on the patch, so is wrong for any linewidth != 1. I'll close this.


		@mpl.style.context('default')
		def test_capstyle():
		col = mcollections.PathCollection([])
Expand Down