NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.3k

Cranky pep8#2930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

pelson merged 2 commits intomatplotlib:masterfromtacaswell:cranky_pep8

Mar 27, 2014

Merged

Cranky pep8#2930

pelson merged 2 commits intomatplotlib:masterfromtacaswell:cranky_pep8

Mar 27, 2014

Conversation

Copy link

Member

tacaswell commentedMar 27, 2014

fixed E713 and E714 because they seem legit.

Everything else was either picking exclusively (until I gave up) on comments or was complaining about

Squelched error code	reasoning
E256	entirely formatting on comments, flags on`#### stuff`
E111, E112, E113	flags entirely on comments, mostly ones that had to get wrapped due to line length issues
E129	issues with continued lines hitting the next true indent, could be sold on really fixing these
E131	issues with indentation of continuation lines not being just right. I think there are common situations where it is in fact impossible to satisfy both E129 and E131

E11{1,2,3} is catching things like

some_code() # this is a long comment            # explaining the code that got            # wrapped like this due to line            # length issues

And I think that

if (food and     bar):    some_stuff()

can not satisfy both E129 and E131

tacaswell added2 commits

March 26, 2014 21:02

PEP8 : fixed all E71[3,4] failures

24085ac

PEP8 : Squelch spurious tests

6464e2d

The new ignore tests (E111, E112, E113, E265) are just picking upstyle infractions on the comments.

tacaswell mentioned this pull request

Mar 27, 2014

Issue 2899#2923

Merged

Copy link

MemberAuthor

tacaswell commentedMar 27, 2014

And now it looks like rabbitmq.com which the travis vm talks to while runningapt-get update is down which is why everything is erroring out in < 1min.