Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

BLD: Pin meson-python to <0.17.0#29295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jklymak merged 1 commit intomatplotlib:mainfromQuLogic:pin-meson-python
Dec 13, 2024

Conversation

QuLogic
Copy link
Member

PR summary

This is currently dropping scalable SVG symlinks, which breaks the toolbar on GTK.

Fixes#29229

PR checklist

@QuLogicQuLogic added Build CI: Run cibuildwheelRun wheel building tests on a PR labelsDec 12, 2024
@github-actionsgithub-actionsbot removed the CI: Run cibuildwheelRun wheel building tests on a PR labelDec 12, 2024
This is currently dropping scalable SVG symlinks, which breaks thetoolbar on GTK.
@QuLogicQuLogic added the CI: Run cibuildwheelRun wheel building tests on a PR labelDec 12, 2024
@QuLogicQuLogic added this to thev3.9.4 milestoneDec 12, 2024
@timhoffm
Copy link
Member

timhoffm commentedDec 12, 2024
edited
Loading

Do we know what in meson 0.17 broke? Is there an upstream bug report? - I'm asking because thats the prerequisite for getting it fixed / unpinning in the future.

@QuLogic
Copy link
MemberAuthor

Yes, it arose frommesonbuild/meson-python#587; I am still investigating if there is a quick way to fix it on our side or whether it will need changes on their side.

timhoffm reacted with thumbs up emoji

@jklymakjklymak merged commita23ef5a intomatplotlib:mainDec 13, 2024
47 checks passed
@lumberbot-appLumberbot (App)
Copy link

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v3.9.xgit pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 a23ef5a8176c08c7f3de4d1a78f9bf075554b2bd
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #29295: BLD: Pin meson-python to <0.17.0'
  1. Push to a named branch:
git push YOURFORK v3.9.x:auto-backport-of-pr-29295-on-v3.9.x
  1. Create a PR against branch v3.9.x, I would have named this PR:

"Backport PR#29295 on branch v3.9.x (BLD: Pin meson-python to <0.17.0)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove theStill Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free tosuggest an improvement.

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestDec 13, 2024
@QuLogicQuLogic deleted the pin-meson-python branchDecember 13, 2024 00:43
QuLogic added a commit to QuLogic/matplotlib that referenced this pull requestDec 13, 2024
QuLogic added a commit that referenced this pull requestDec 13, 2024
…3.9.xBackport PR#29295 on branch v3.9.x (BLD: Pin meson-python to <0.17.0)
QuLogic added a commit that referenced this pull requestDec 13, 2024
…295-on-v3.10.xBackport PR#29295 on branch v3.10.x (BLD: Pin meson-python to <0.17.0)
@QuLogic
Copy link
MemberAuthor

I've openedmesonbuild/meson-python#713 for meson-python upstream, and we can unpin once that is out in a release.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jklymakjklymakjklymak approved these changes

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Labels
BuildCI: Run cibuildwheelRun wheel building tests on a PR
Projects
None yet
Milestone
v3.9.4
Development

Successfully merging this pull request may close these issues.

[Bug]: Icons do not work with GTK
3 participants
@QuLogic@timhoffm@jklymak

[8]ページ先頭

©2009-2025 Movatter.jp