Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Exclude pylab from mypy checks#29267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tacaswell merged 1 commit intomatplotlib:mainfromrcomer:mypy-pylab
Dec 9, 2024
Merged

Conversation

rcomer
Copy link
Member

PR summary

Aiming toclose#29263.

PR checklist

@rcomerrcomerforce-pushed themypy-pylab branch 2 times, most recently from62cc501 to181a5eaCompareDecember 9, 2024 16:46
@rcomer
Copy link
MemberAuthor

pylab is already in the stubtest allowlist

matplotlib\.pylab\..*

I thought this would be simple but apparently I am out of my depth.

@rcomer
Copy link
MemberAuthor

The error is

error: not checking stubs due to mypy build errors

😕

@timhoffm
Copy link
Member

At least the mypy linting action is happy. That's half way 😄.

Not an expert, but I would have tried to mess with this part as well:

#stubtest
".*/matplotlib/(sphinxext|backends|testing/jpl_units)",

rcomer reacted with laugh emojircomer reacted with eyes emoji

@rcomer
Copy link
MemberAuthor

Success 🎉

timhoffm reacted with rocket emoji

@@ -1,7 +1,7 @@
# Non-typed (and private) modules/functions
matplotlib\.backends\..*
matplotlib\.tests(\..*)?
matplotlib\.pylab\..*
matplotlib\.pylab(\..*)?
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Without this change, stubtest both complains that it can't find a stub for pylab and that the allowlist entry is unused. Removing the entry only solved the second complaint. It seemed intuitive to make this line look like thesphinxext line.

timhoffm reacted with thumbs up emoji
@timhoffmtimhoffm added this to thev3.10.0 milestoneDec 9, 2024
@tacaswelltacaswell merged commit35d470a intomatplotlib:mainDec 9, 2024
35 of 36 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestDec 9, 2024
@rcomerrcomer deleted the mypy-pylab branchDecember 9, 2024 19:18
greglucas added a commit that referenced this pull requestDec 9, 2024
…267-on-v3.10.xBackport PR#29267 on branch v3.10.x (Exclude pylab from mypy checks)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.10.0
Development

Successfully merging this pull request may close these issues.

[Bug]: mypy failures in CI
3 participants
@rcomer@timhoffm@tacaswell
[8]ページ先頭
©2009-2025 Movatter.jp