Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix typo#29257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
story645 merged 1 commit intomatplotlib:mainfromvaerksted:main
Dec 8, 2024
Merged

fix typo#29257

story645 merged 1 commit intomatplotlib:mainfromvaerksted:main
Dec 8, 2024

Conversation

musvaage
Copy link
Contributor

solitary fix for a single .rst file

Copy link
Member

@story645story645 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for catching this!

@story645story645 merged commitb358c98 intomatplotlib:mainDec 8, 2024
17 of 21 checks passed
@musvaage
Copy link
ContributorAuthor

musvaage commentedDec 8, 2024
edited
Loading

Typos in pull names are of course not slated to be changed.

The following wasn't directly obvious as to what a fix would be; it is quite old anyways.

$ grep -nr compilex matplotlibmatplotlib/doc/users/prev_whats_new/changelog.rst:6117:    are Numeric typecodes and can be used with Numeric compilex extensions.$

Should becompiled extensions, but maybe such old changelog isn't worth modifying

If I get around to checking the rest of the repo files I'll mention this in another PR.

@WeatherGod
Copy link
Member

WeatherGod commentedDec 9, 2024 via email

compilex --> compiled
On Sun, Dec 8, 2024 at 2:15 PM musvaage ***@***.***> wrote: Typos in pull names are of course not slated to be changed. The following wasn't directly obvious as to what a fix would be; it is quite old anyways. $ grep -nr compilex matplotlib matplotlib/doc/users/prev_whats_new/changelog.rst:6117: are Numeric typecodes and can be used with Numeric compilex extensions. $ — Reply to this email directly, view it on GitHub <#29257 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACHF6FWEXB6NXXJQ7XBX5D2ESLDTAVCNFSM6AAAAABTHOODMKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMRWGMZTQOJSHA> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

@musvaage
Copy link
ContributorAuthor

compilex --> compiled

doc/devel/development_setup.rst

that's a logical conclusion as the stringcompiled extension appears in the above file

@QuLogicQuLogic added this to thev3.11.0 milestoneDec 10, 2024
@musvaage
Copy link
ContributorAuthor

musvaage commentedDec 10, 2024
edited
Loading

Some possible additional fixes.

Homogeneous
compiled
example
functionality
installed
logger
parameters
reset
secondary
tolerance

$ grep -nr Homogenous matplotlibmatplotlib/galleries/users_explain/axes/constrainedlayout_guide.py:535:plt.suptitle('Homogenous nrows, ncols')$ grep -nr compilex matplotlibmatplotlib/doc/users/prev_whats_new/changelog.rst:6117:    are Numeric typecodes and can be used with Numeric compilex extensions.$ grep -nr exammple matplotlibmatplotlib/lib/matplotlib/sphinxext/plot_directive.py:35:        plt.title("A plotting exammple")$ grep -nr functionaliy matplotlibmatplotlib/doc/api/next_api_changes/removals/20866-JKS.rst:5:functionaliy was already replaced by other code, and the only thing left$ grep -nr instaled matplotlibmatplotlib/pyproject.toml:54:    # Unfortunately, we can't do a sort of minimum-if-instaled dependency, so$ grep -nr looger matplotlibmatplotlib/doc/api/prev_api_changes/api_changes_3.1.0.rst:536:    # e.g. by configuring a root looger using ``logging.basicConfig()``,$ grep -n parmeters matplotlib/lib/matplotlib/tests/test_colorbar.py1211:def test_colorbar_axes_parmeters():$ grep -nr resete matplotlibmatplotlib/lib/matplotlib/tests/test_widgets.py:1602:    # selector should be automatically resete$ grep -nr secondart matplotlibmatplotlib/lib/matplotlib/axes/_base.py:1071:            The transform used for drawing secondart y-axis labels, which will$ grep -nr tolerence matplotlibmatplotlib/doc/api/prev_api_changes/api_changes_3.1.0.rst:798:- The *tolerence* parameter to$

Should the blank space be removed?

$ grep -n "pass throughs" matplotlib/lib/matplotlib/category.py54:        # dtype = object preserves numerical pass throughs$

I presume this is intentional.

$ grep -nr hozirontal matplotlibmatplotlib/lib/matplotlib/tests/test_text.py:412:        Text(rotation='hozirontal')$

This seems to be bundled customised code.

$ grep -nr intialization matplotlibmatplotlib/subprojects/packagefiles/freetype-2.6.1-meson/include/freetype/config/ftoption.h.in:491:  /*   constants will be moved into a struct and additional intialization  */$

ci/schemas/conda-environment.json

The above bundled file's typo has been fixed upstream.

microsoft/vscode-python#24574

lib/matplotlib/_color_data.py

The above file contains reproduced xkcd site content which includes typos found in the original.

@musvaage
Copy link
ContributorAuthor

@story645

I can open a new PR if the matters addressed in my previous comment are of interest.

@QuLogic
Copy link
Member

Sure, people probably aren't going to look at a closed PR much.

@story645
Copy link
Member

Sorry for not getting back to it, agree w/@QuLogic with the caveat that you shouldn't bother w/ anything in the changelog.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@story645story645story645 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.11.0
Development

Successfully merging this pull request may close these issues.

4 participants
@musvaage@WeatherGod@QuLogic@story645

[8]ページ先頭

©2009-2025 Movatter.jp