Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
fix typo#29257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
fix typo#29257
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for catching this!
b358c98
intomatplotlib:mainUh oh!
There was an error while loading.Please reload this page.
musvaage commentedDec 8, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Typos in pull names are of course not slated to be changed. The following wasn't directly obvious as to what a fix would be; it is quite old anyways.
Should be If I get around to checking the rest of the repo files I'll mention this in another PR. |
compilex --> compiled …On Sun, Dec 8, 2024 at 2:15 PM musvaage ***@***.***> wrote: Typos in pull names are of course not slated to be changed. The following wasn't directly obvious as to what a fix would be; it is quite old anyways. $ grep -nr compilex matplotlib matplotlib/doc/users/prev_whats_new/changelog.rst:6117: are Numeric typecodes and can be used with Numeric compilex extensions. $ — Reply to this email directly, view it on GitHub <#29257 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACHF6FWEXB6NXXJQ7XBX5D2ESLDTAVCNFSM6AAAAABTHOODMKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMRWGMZTQOJSHA> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***> |
doc/devel/development_setup.rst that's a logical conclusion as the string |
musvaage commentedDec 10, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Some possible additional fixes. Homogeneous
Should the blank space be removed?
I presume this is intentional.
This seems to be bundled customised code.
ci/schemas/conda-environment.json The above bundled file's typo has been fixed upstream. lib/matplotlib/_color_data.py The above file contains reproduced xkcd site content which includes typos found in the original. |
I can open a new PR if the matters addressed in my previous comment are of interest. |
Sure, people probably aren't going to look at a closed PR much. |
Sorry for not getting back to it, agree w/@QuLogic with the caveat that you shouldn't bother w/ anything in the changelog. |
solitary fix for a single .rst file