Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Bug Fix] Fix reverse mapping for _translate_tick_params#29249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
rcomer merged 2 commits intomatplotlib:mainfromkyracho:kw_translation_bugfix
Dec 8, 2024

Conversation

kyracho
Copy link
Contributor

@kyrachokyracho commentedDec 7, 2024•
edited
Loading

PR summary

Hi. This fixes a bug in_translate_tick_params where some keys are not being mapped correctly withreverse=True andcls.axis_name = 'x'.

For example, both 'left' and 'bottom' are mapped to 'tick1On', making the reverse ambiguous.

Separated from#28968 because this is an independent bug.

PR checklist

Copy link
Member

@timhoffmtimhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for splitting.

Note: Test failures are unrelated.

kyracho reacted with heart emoji
@QuLogic
Copy link
Member

I thought we already had a PR for this; did it not get merged?

@rcomer
Copy link
Member

This fixes#27416, which does have two existing PRs but both seem to have stalled.

timhoffm reacted with thumbs up emoji

@rcomerrcomer linked an issueDec 7, 2024 that may beclosed by this pull request
Co-authored-by: Ruth Comer <10599679+rcomer@users.noreply.github.com>
@rcomerrcomer added this to thev3.10.0 milestoneDec 8, 2024
@rcomerrcomer merged commit9af426b intomatplotlib:mainDec 8, 2024
39 checks passed
@rcomer
Copy link
Member

Thanks@kyracho!

kyracho reacted with heart emoji

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestDec 8, 2024
@kyrachokyracho deleted the kw_translation_bugfix branchDecember 8, 2024 09:20
rcomer added a commit that referenced this pull requestDec 8, 2024
…249-on-v3.10.xBackport PR#29249 on branch v3.10.x ([Bug Fix] Fix reverse mapping for _translate_tick_params)
@timhoffmtimhoffm mentioned this pull requestDec 9, 2024
4 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@timhoffmtimhoffmtimhoffm approved these changes

@rcomerrcomerrcomer approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.10.0
Development

Successfully merging this pull request may close these issues.

[Bug]: get_tick_params on xaxis shows wrong keywords
4 participants
@kyracho@QuLogic@rcomer@timhoffm
[8]ページ先頭
©2009-2025 Movatter.jp