Corrected theindicate_inset docstring, as we are definitelydefaulting to transData.
Currently the ends of the connectors that meet the box do not use the passed transform. So againstmain, my new image test gives
Set theaxes property on the rectangle so thatCartopy transforms will work, and we can do things like

importmatplotlib.pyplotaspltimportcartopy.crsasccrsimportcartopy.featureascfeaturemain_map_proj=ccrs.TransverseMercator()pcarree=ccrs.PlateCarree()fig,ax=plt.subplots(subplot_kw={"projection":main_map_proj})ax.set_extent([-50,15,50,70],crs=pcarree)ax.add_feature(cfeature.OCEAN.with_scale('50m'),facecolor="lightsteelblue",zorder=1,edgecolor="k",lw=0.2)inset_ax=ax.inset_axes((0.05,0.05,0.3,0.3),projection=pcarree)inset_extent= [-44,-38,63,66]inset_ax.set_extent(inset_extent,crs=pcarree)inset_ax.add_feature(cfeature.OCEAN,facecolor="lightsteelblue",zorder=1)ax.indicate_inset_zoom(inset_ax,edgecolor="black",transform=pcarree)x= [inset_extent[0],inset_extent[1],inset_extent[1],inset_extent[0]]y= [inset_extent[2],inset_extent[2],inset_extent[3],inset_extent[3]]forainax,inset_ax:a.scatter(x,y,c=range(4),s=150,transform=pcarree)plt.show()

PR checklist

[n/a] "closes #0000" is in the body of the PR description tolink the related issue
new and changed code istested
[n/a]Plotting related features are demonstrated in anexample
[n/a]New Features andAPI Changes are noted with adirective and release note
Documentation complies withgeneral anddocstring guidelines

rcomer commented

Nov 22, 2024

View reviewed changes

lib/matplotlib/inset.py OutdatedShow resolvedHide resolved

rcomer marked this pull request as draft

November 22, 2024 20:12

rcomer force-pushed theinset-conn-transform branch 2 times, most recently fromc8e7643 toba851c1Compare

November 22, 2024 20:43

rcomer commented

Nov 22, 2024

View reviewed changes

lib/matplotlib/tests/test_inset.py



		@image_comparison(['zoom_inset_transform.png'], remove_text=True, style='mpl20',
		tol=0.01)

Copy link

MemberAuthor

rcomerNov 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

MacOS tests need the 0.01 tolerance.

rcomer marked this pull request as ready for review

November 22, 2024 21:14

rcomer mentioned this pull request

Nov 22, 2024

indicate_inset_zoom not working on some projectionsSciTools/cartopy#2482

Open

rcomer force-pushed theinset-conn-transform branch 2 times, most recently from470b488 to0d57221Compare

November 22, 2024 21:52

indicate_inset transform support

95ed490

rcomer force-pushed theinset-conn-transform branch from0d57221 to95ed490Compare

November 23, 2024 08:40

rcomer commented

Nov 23, 2024

View reviewed changes

lib/matplotlib/inset.py

		# Set axes on the rectangle (required for some external transforms to work) as
		# well as the InsetIndicator artist.
		self.rectangle.axes = new_axes
		artist.Artist.axes.fset(self, new_axes)

Copy link

MemberAuthor

rcomerNov 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I copied the setter logic here from theartist within artist example. I would not have figured it out by myself - thanks@QuLogic for putting it in the example!