Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

ci: Remove Linux & macOS from Azure#29171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ksunden merged 3 commits intomatplotlib:mainfromQuLogic:less-ci
Nov 27, 2024
Merged

Conversation

QuLogic
Copy link
Member

PR summary

After an audit of all CI, we don't believe we are gaining anything by duplicating GitHub Actions here.

PR checklist

@QuLogicQuLogic added the CI: testingCI configuration and testing labelNov 22, 2024
@QuLogic
Copy link
MemberAuthor

QuLogic commentedNov 22, 2024
edited
Loading

For the record, the system Linux packages explicitly installed on GitHub Actions, but not Azure are:

  • ccache
  • libcairo2-dev
  • libffi-dev
  • libgeos-dev
  • libgirepository1.0-dev
  • libsdl2-2.0-0
  • libxkbcommon-x11-0
  • libxcb-cursor0
  • libxcb-icccm4
  • libxcb-image0
  • libxcb-keysyms1
  • libxcb-randr0
  • libxcb-render-util0
  • libxcb-xinerama0
  • pkg-config
  • qtbase5-dev

and vice versa:

  • libgirepository-1.0-1
  • poppler-utils

On macOS, GitHub Actions has:

  • ghostscript
  • gobject-introspection
  • gtk4
  • font-noto-sans-cjk
  • inkscape

whereas for Azure its:

  • ffmpeg
  • imagemagick
  • mplayer
  • pkg-config
  • font-noto-sans-cjk-sc
  • xquartz

It also turns out that we never uploaded macOS coverage reports, so coverage is only down by 2 report from Linux. The coverage change shows that we lost:

  • pdftocairo
  • xpdf
  • pdftops

I think these would have all come frompoppler-utils. I don't think we are missing any backends, specifically. Possibly on macOS, we may also want to add ffmpeg? But that's definitely caught by Linux builds.

@oscargus
Copy link
Member

Do we know if xquartz is installed on GitHub or if it actually wasn't needed for Azure? It seems like the GUI-tests does not complain at least?

Interesting that a bit of the "executable not available"-tests lost coverage. Probably not worthwhile to have separate pipeline for those, but one may expect the minimum version test to handle them? Or maybe they are skipped earlier in the process? Is it worthwhile to setup a "minimum requirements" test (unless that is actually included in minimum versions)?

@tacaswell
Copy link
Member

https://app.codecov.io/gh/matplotlib/matplotlib/pull/29171/blob/lib/matplotlib/backends/backend_pgf.py#L170

It looks like we supportpdftocairo andgs for getting raster images out of pgf but always havepdftocairo installed so never testgs. If this is what was before, lets open an issue to look at it, if this is new can we get one job that uses ps (I have not chased things back, but I have a suspicion thatpdftocairo is a system dependency of something we depend on for pgf).

Can we drop ffmpeg on the minimal deps run?

@QuLogic
Copy link
MemberAuthor

Do we know if xquartz is installed on GitHub or if it actually wasn't needed for Azure? It seems like the GUI-tests does not complain at least?

I think this may have been for GTK2. I don't recall if GTK3 used XQuartz, but GTK4 should be native. So I removed it and everything seems fine.

Interesting that a bit of the "executable not available"-tests lost coverage. Probably not worthwhile to have separate pipeline for those, but one may expect the minimum version test to handle them? Or maybe they are skipped earlier in the process? Is it worthwhile to setup a "minimum requirements" test (unless that is actually included in minimum versions)?

It looks like we supportpdftocairo andgs for getting raster images out of pgf but always havepdftocairo installed so never testgs. If this is what was before, lets open an issue to look at it, if this is new can we get one job that uses ps (I have not chased things back, but I have a suspicion thatpdftocairo is a system dependency of something we depend on for pgf).

These were from addingpoppler-utils; I've left it out of the minimum versions build and now both of those code paths are touched.

Can we drop ffmpeg on the minimal deps run?

Yes, did that as well.

@tacaswelltacaswell added this to thev3.11.0 milestoneNov 27, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell approved these changes

@ksundenksundenksunden approved these changes

Assignees
No one assigned
Labels
CI: testingCI configuration and testing
Projects
None yet
Milestone
v3.11.0
Development

Successfully merging this pull request may close these issues.

4 participants
@QuLogic@oscargus@tacaswell@ksunden

[8]ページ先頭

©2009-2025 Movatter.jp