NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.3k

FUTURE BUG: reconsider how we deep-copy path objects #29157#29161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

saikarna913 wants to merge2 commits intomatplotlib:mainfromsaikarna913:Feature2

Closed

FUTURE BUG: reconsider how we deep-copy path objects #29157#29161

saikarna913 wants to merge2 commits intomatplotlib:mainfromsaikarna913:Feature2

Conversation

Copy link

Contributor

saikarna913 commentedNov 20, 2024

PR summary

it is necessary to solve the infinite recursion in__deep_copy__ function in path.py
it is creating the deep copy without infinite recursion
adding the memo dictionary with id as the self and value as the new instance created , makes the deep copy to stop the infinite recursion when same class is called since in MRO, the object will be the path class since there are no super classes for the path class which searches for__deep_copy__

PR checklist

"closesFUTURE BUG: reconsider how we deep-copy path objects #29157 " is in the body of the PR description to (FUTURE BUG: reconsider how we deep-copy path objects #29157)

Update path.py

29f6618

github-actionsbot added the topic: path handling label

Nov 20, 2024

github-actionsbot reviewed

Nov 20, 2024

View reviewed changes

Copy link

github-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join uson gitter for real-time discussion.

For details on testing, writing docs, and our review process, please seethe developer guide

We strive to be a welcoming and open project. Please follow ourCode of Conduct.

Copy link

Member

tacaswell commentedNov 20, 2024

See#21280 for the context of why we are usingsuper(). We want to say "do the normal deepcopy thing and then make an extra change before it goes back to the user" and the original motivation for this was to fix deepcopy forPath sub-classes wheresuper() may have a non-trivial MRO to walk.

Merge branch 'matplotlib:main' into Feature2

5904179

Copy link

Member

rcomer commentedNov 24, 2024

This PR requires a high level of python knowledge/experience, certainly beyond my level.@saikarna913 since you have opened a new PR against an easier issue, did you decide this one is also beyond your level? If so we should close this to signal to other contributors that the issue is available to work on.