Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Uptade fix number of levels with log contour#29137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
@@ -960,13 +960,12 @@ def changed(self): | |||
label.set_color(self.labelMappable.to_rgba(cv)) | |||
super().changed() | |||
def _autolev(self, N): | |||
def _autolev(self, N, *, using_default): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think this extra argument is not necessary.
The only place where this is passed it is simply aN is not None
(on the input side, but the effect is the same)
So even if the variable is useful, it can be computed internally.
However, even further, the difference betweenLogLocator()
andLogLocator(numticks=N)
whenN
isNone
is nothing, therefore you can just pass it as a kwarg.
Haven't fully thought through the last portion (adjustments if levels are still insufficient) and if there may need to be at least aif N is not None
in there potentially, but not sure yet.
Uh oh!
There was an error while loading.Please reload this page.
PR summary
By passing an integer value in the levels argument to specify the maximum number of contour levels, the program didn't always respect this limit in practice.
Adjusts the behavior so that the number of contour levels is generated as requested, even when using a logarithmic scale.
Fix#27576
PR checklist