Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Uptade fix number of levels with log contour#29137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
ebarcelosf wants to merge1 commit intomatplotlib:main
base:main
Choose a base branch
Loading
fromebarcelosf:issue2

Conversation

ebarcelosf
Copy link

@ebarcelosfebarcelosf commentedNov 13, 2024
edited
Loading

PR summary

By passing an integer value in the levels argument to specify the maximum number of contour levels, the program didn't always respect this limit in practice.
Adjusts the behavior so that the number of contour levels is generated as requested, even when using a logarithmic scale.
Fix#27576

PR checklist

@@ -960,13 +960,12 @@ def changed(self):
label.set_color(self.labelMappable.to_rgba(cv))
super().changed()

def _autolev(self, N):
def _autolev(self, N, *, using_default):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think this extra argument is not necessary.

The only place where this is passed it is simply aN is not None (on the input side, but the effect is the same)

So even if the variable is useful, it can be computed internally.

However, even further, the difference betweenLogLocator() andLogLocator(numticks=N) whenN isNone is nothing, therefore you can just pass it as a kwarg.

Haven't fully thought through the last portion (adjustments if levels are still insufficient) and if there may need to be at least aif N is not None in there potentially, but not sure yet.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ksundenksundenksunden left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Projects
Status: Waiting for author
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@ebarcelosf@ksunden

[8]ページ先頭

©2009-2025 Movatter.jp