Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Make ListedColormap.monochrome a property#29125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
5827742 to6b1ce2aComparetimhoffm commentedNov 12, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I get Note: Discussion moved to#29129. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍 This is easier to follow.
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Feel free to self merge plus or minus@greglucas comment
The calculated property replaces the attribute *monochome*, which wasmanually set on `__init__`, but was not correctly set for all possibleinputs.This property ensures consistency and simplifies initialization at thecost of some computation overhead to determine whether the colormap ismonochrome.The computation cost is bearable (even without caching), because it'sonly used in `ContourSet._process_colors`.It's a separate discussion whether we need this property on colormaps atall (at least as public API). Usually, colormaps are not monochromeand monochrome colormaps are a very special edge case used in contoursonly. We may eventually deprecate it, but since it is currently publicAPI, let's leave it for now.There's also a technical API incompatibility in that users cannot setthe attribute anymore, but I'd argue that that has never been intendedand there's no practical use-case, so I refrain from the extra hassleof allowing setting this property.Co-authored-by: Greg Lucas <greg.m.lucas@gmail.com>
5e48fd8 toce488f5Compare464c8e8 intomatplotlib:mainUh oh!
There was an error while loading.Please reload this page.
The calculated property replaces the attributemonochome, which was manually set on
__init__, but was not correctly set for all possible inputs.This property ensures consistency and simplifies initialization at the cost of some computation overhead to determine whether the colormap is monochrome.
The computation cost is bearable (even without caching), because it's only used in
ContourSet._process_colors.It's a separate discussion whether we need this property on colormaps at all (at least as public API). Usually, colormaps are not monochrome and monochrome colormaps are a very special edge case used in contours only. We may eventually deprecate it, but since it is currently public API, let's leave it for now.
There's also a technical API incompatibility in that users cannot set the attribute anymore, but I'd argue that that has never been intended and there's no practical use-case, so I refrain from the extra hassle of allowing setting this property.