Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
FIX: Update GTK3Agg backend export name for consistency#29085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
timhoffm approved these changesNov 5, 2024
QuLogic approved these changesNov 5, 2024
1155eab intomatplotlib:main 42 checks passed
Uh oh!
There was an error while loading.Please reload this page.
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestNov 5, 2024
QuLogic added a commit that referenced this pull requestNov 6, 2024
…085-on-v3.10.xBackport PR#29085 on branch v3.10.x (FIX: Update GTK3Agg backend export name for consistency)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Reading through the code I found it weird that the backend export class is called "Cairo" within the "Agg" section, I think this was just a typo originally in#8773. The actual monkeypatching happens based on the module name,
matplotlib/lib/matplotlib/backend_bases.py
Line 3562 in0b6222b
not this class so we were using the proper Agg/Cairo renderers as expected. This just helps with naming consistency when looking through the code.