Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Updates thegalleries/tutorials/artists.py file in response to issue #28920#29080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join uson gitter for real-time discussion.
For details on testing, writing docs, and our review process, please seethe developer guide
We strive to be a welcoming and open project. Please follow ourCode of Conduct.
galleries/tutorials/artists.py Outdated
| # stored as member variables :attr:`!Figure.patch | ||
| # <matplotlib.figure.Figure.patch>` and :attr:`!Axes.patch | ||
| # <matplotlib.axes.Axes.patch>` ("Patch" is a name inherited from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| # stored as member variables :attr:`!Figure.patch | |
| # <matplotlib.figure.Figure.patch>` and :attr:`!Axes.patch | |
| # <matplotlib.axes.Axes.patch>` ("Patch" is a name inherited from | |
| # stored as member variables :attr:`!Figure.patch` and | |
| # :attr:`!Axes.patch` ("Patch" is a name inherited from |
The explicit targets are not needed when we don't link and actually would render verbatim. Compare this
to the original
Please update all other occurences accoringly as well.
Ping@story645. This is something to be aware of for similar PRs.
| @@ -11,15 +11,15 @@ | |||
| There are three layers to the Matplotlib API. | |||
| * the :class:`matplotlib.backend_bases.FigureCanvas` is the area onto which | |||
| * the :class:`!matplotlib.backend_bases.FigureCanvas` is the area onto which | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Actually, the previous way of expression is not exactly great - there is just no classmatplotlib.backend_bases.FigureCanvas. We have a logical concept ofFigureCanvas that's realized through the subclasses ofFigureCanvasBase. Maybe
| *the:class:`!matplotlib.backend_bases.FigureCanvas`istheareaontowhich | |
| *the*FigureCanvas* (subclassesof`.FigureCanvasBase`)istheareaontowhich |
And subsequently only use FigureCanvas as a given name (for the logical concept) without further highlighting.
Or better, switch to:term:`FigureCanvas`, but that'd require first setting up a gloassary#28889.
But we can also leave all this for later.
| the figure is drawn | ||
| * the :class:`matplotlib.backend_bases.Renderer` is the object which knows how | ||
| to draw on the :class:`~matplotlib.backend_bases.FigureCanvas` | ||
| * the :class:`!matplotlib.backend_bases.Renderer` is the object which knows how |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Same issue as above:Renderer is a concept realized through the subclasses ofRendererBase.
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Let's take this as an incremental improval. And decouple from possible wording improvements.
55fa822 intomatplotlib:mainUh oh!
There was an error while loading.Please reload this page.
…s.py` file in response to issuematplotlib#28920
Thanks@focardozom |
PR summary
This pull request addressesissue #28920 by updating the
galleries/tutorials/artists.pyfile to allow suppressing missing references using a!prefix, rather than themissing_referencesextension.PR checklist
galleries/tutorials/artists.pyfile in response toissue #28920.