Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
[DOC] Update missing-references.json#29058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This seems to have had the opposite effect; more warnings are issued afaict. |
Yeah, seeing if it was a version problem on my local env... |
Problems were introduced bymatplotlib#28048, specifically relating to set_sizes. I simply ran with the flag to regenerate, so more changes were made, which I do not fully understand why they were not problematic earlier.
Running updates helped, but one tutorial file (artists) was off by 3 lines somehow... I think it should be good now... |
9b8f11b intomatplotlib:mainUh oh!
There was an error while loading.Please reload this page.
It has to do with how Artist docstrings are rendered, which includes some templating. We noticed the doc build failure on the PR, but we're not 100% sure it would be a problem once merged, so we went through with the merge and sorted it out after it did indeed fail. In short, there are cross references in the docs that are pointing to methods that aren't actually rendered in the docs (because they exist on a private class). We have a way of ignoring the errors, but it relies on the line number matching, so if something changes (in this case I think it was adding a method) the ignores need updating. |
I see, thanks! |
Problems were introduced by#28048, specifically relating to set_sizes.
I simply ran with the flag to regenerate, so more changes were made, which I do not fully understand why they were not problematic earlier.
PR summary
PR checklist