Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Bump required pybind11 to 2.13#29012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tacaswell merged 1 commit intomatplotlib:mainfromQuLogic:bump-pybind
Oct 23, 2024
Merged

Conversation

QuLogic
Copy link
Member

PR summary

This is necessary for thepy::mod_gil_not_used tag. Note that this if fairly new, so we could go the other route and#if the tag.

Seehttps://matrix.to/#/!BXmyZMTnRjWJldDRLV:gitter.im/$Bsyuv1YBdUjtHnJLP1jE7KjYdk5O6DVBzfG6giPd-D0?via=gitter.im&via=matrix.org&via=aria-net.org

PR checklist

This is necessary for the `py::mod_gil_not_used` tag.
@tacaswelltacaswell added this to thev3.9.3 milestoneOct 23, 2024
@tacaswell
Copy link
Member

#29014 fixes the mypy issue, merging over that failure.

@tacaswelltacaswell merged commit41be3a0 intomatplotlib:mainOct 23, 2024
45 of 46 checks passed
@lumberbot-appLumberbot (App)
Copy link

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v3.9.xgit pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 41be3a05797a7827fb4e27d7c1edda4a22a6036a
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #29012: Bump required pybind11 to 2.13'
  1. Push to a named branch:
git push YOURFORK v3.9.x:auto-backport-of-pr-29012-on-v3.9.x
  1. Create a PR against branch v3.9.x, I would have named this PR:

"Backport PR#29012 on branch v3.9.x (Bump required pybind11 to 2.13)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove theStill Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free tosuggest an improvement.

@QuLogic
Copy link
MemberAuthor

No need for backport; this flag was only flipped onmain.

@QuLogicQuLogic deleted the bump-pybind branchOctober 24, 2024 03:27
@QuLogicQuLogic modified the milestones:v3.9.3,v3.10.0Oct 24, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell approved these changes

@greglucasgreglucasgreglucas approved these changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
v3.10.0
Development

Successfully merging this pull request may close these issues.

3 participants
@QuLogic@tacaswell@greglucas
[8]ページ先頭
©2009-2025 Movatter.jp