Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Fix: Do not use numeric tolerances for axline special cases#28987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
vertical lines (infinite slope) and two identical points as input need special handling in AxLine. The detection was using numeric tolerances, which lead to false-positive detection in cases that are close to but not exactly those special cases.This PR removes the tolerances. The argument is the same as for the similar casematplotlib#28386 (comment)Closesmatplotlib#28870.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This closes out the last of the comparisons called out in this comment, lgtm!#28386 (comment)
This might be better considered as a bugfix for the 3.9.3 milestone. |
c236102 intomatplotlib:mainUh oh!
There was an error while loading.Please reload this page.
…axline special cases
…987-on-v3.9.xBackport PR#28987 on branch v3.9.x (Fix: Do not use numeric tolerances for axline special cases)
vertical lines (infinite slope) and two identical points as input need special handling in AxLine. The detection was using numeric tolerances, which lead to false-positive detection in cases that are close to but not exactly those special cases.
This PR removes the tolerances. The argument is the same as for the similar case#28386 (comment)
Closes#28870.