Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
BLD: Implement PEP639 licensing#28982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This allows developers to test out the build locally. With this, I wasable to fix the test command by setting `PIP_PREFER_BINARY` to avoidre-building Pillow, which accidentally dropped manylinux2014 wheels inthe latest release:python-pillow/Pillow#9057Note also that we previously set `CIBW_AFTER_BUILD`, but this doesn'tseem to be a valid setting. Thus I have dropped the `twine check`, whichonly tests the `README` rendering and so checking the sdist issufficient. Additionally, I have commented out the license check, as wecannot do multiple licenses with meson-python without PEP639 (matplotlib#28982).
This allows developers to test out the build locally. With this, I wasable to fix the test command by setting `PIP_PREFER_BINARY` to avoidre-building Pillow, which accidentally dropped manylinux2014 wheels inthe latest release:python-pillow/Pillow#9057Note also that we previously set `CIBW_AFTER_BUILD`, but this doesn'tseem to be a valid setting. Thus I have dropped the `twine check`, whichonly tests the `README` rendering and so checking the sdist issufficient. Additionally, I have commented out the license check, as wecannot do multiple licenses with meson-python without PEP639 (matplotlib#28982).
Note, this is now working, I think, but it would require meson-python 0.18, which was only released in April of this year, and Meson 1.6, released October last year. |
rgommers commentedJul 8, 2025
This is looking pretty good to me.
I wouldn't worry about that, using recent build dependencies is almost never a problem. The more relevant constraint is that this drops support for older |
I'm not sure if that's a problem; I used pip 24.3.1 to install from this branch and from the wheels generated in CI without any issues. |
rgommers commentedJul 10, 2025
Hmm interesting. The wheels do contain |
Uh oh!
There was an error while loading.Please reload this page.
PR summary
Note that this would require meson-python 0.18.0, which was only released in May 2025, so we may not want to include this just yet.
It does fix the issue that that wheels do not include all licenses that we have in the sdist. Because of some discussion about the dynamicity of the license(-files) key, it doesnot automatically include the licenses of subprojects.
PR checklist