Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Switch macOS 12 runner images to macOS 13#28972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ksunden merged 2 commits intomatplotlib:mainfromQuLogic:ci-macos13
Oct 17, 2024

Conversation

QuLogic
Copy link
Member

PR summary

These are going away soon, so let's see how this works out.

actions/runner-images#10721

This may be the last Intel macOS left now.

PR checklist

@github-actionsgithub-actionsbot added the CI: Run cibuildwheelRun wheel building tests on a PR labelOct 12, 2024
@QuLogicQuLogic added the CI: testingCI configuration and testing labelOct 12, 2024
@QuLogic
Copy link
MemberAuthor

Looks like even on macOS 13, the Homebrew Python installation is still broken.

if [[ "${{ matrix.os }}" = macos-14 ]]; then
brew install gobject-introspection gtk4
fi
brew install ccache ghostscript gobject-introspection gtk4 ninja
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
brew install ccache ghostscriptgobject-introspection gtk4ninja
brew install ccache ghostscript ninja

will this skip the Python update?

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Ah right, maybe I'll put the condition back in.

These are going away soon, so let's see how this works out.actions/runner-images#10721
@QuLogicQuLogicforce-pushed theci-macos13 branch 2 times, most recently fromaa27cb5 to3fd066aCompareOctober 17, 2024 00:38
We don't care about system Python, as we use `actions/setup-python` (onGitHub) or `UsePythonVersion` (on Azure), which install in some otherlocation and adjust the `PATH`. But occasionally, Homebrew will fail toupdate these files because they didn't come from Homebrew, so justsilence its complaints.
@QuLogic
Copy link
MemberAuthor

I've given up hoping thatactions/runner-images#9966 will ever be fixed properly. So instead, implemented some forced linking that I found in related discussion.

@QuLogicQuLogic marked this pull request as ready for reviewOctober 17, 2024 01:15
@QuLogicQuLogic added this to thev3.9.3 milestoneOct 17, 2024
@ksundenksunden merged commitfd452d2 intomatplotlib:mainOct 17, 2024
46 of 47 checks passed
@lumberbot-appLumberbot (App)
Copy link

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v3.9.xgit pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 fd452d20bc4dd2eac6b028461e9c92adbbdcda1f
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #28972: Switch macOS 12 runner images to macOS 13'
  1. Push to a named branch:
git push YOURFORK v3.9.x:auto-backport-of-pr-28972-on-v3.9.x
  1. Create a PR against branch v3.9.x, I would have named this PR:

"Backport PR#28972 on branch v3.9.x (Switch macOS 12 runner images to macOS 13)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove theStill Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free tosuggest an improvement.

@QuLogicQuLogic deleted the ci-macos13 branchOctober 17, 2024 19:13
QuLogic added a commit to QuLogic/matplotlib that referenced this pull requestOct 17, 2024
QuLogic added a commit that referenced this pull requestOct 18, 2024
…3.9.xBackport PR#28972 on branch v3.9.x (Switch macOS 12 runner images to macOS 13)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell approved these changes

@ksundenksundenksunden approved these changes

Assignees
No one assigned
Labels
CI: Run cibuildwheelRun wheel building tests on a PRCI: testingCI configuration and testing
Projects
None yet
Milestone
v3.9.3
Development

Successfully merging this pull request may close these issues.

3 participants
@QuLogic@tacaswell@ksunden
[8]ページ先頭
©2009-2025 Movatter.jp