Once explicitly set, the implicit machinery will not override the converter.
Previously (and still, if not explicitly set), the converter would be reset each time new data was added, possibly setting to something incompatible with previously provided data.

You cannot reset the converter once explicitly provided (except by clearing the axis entirely).
A warning is provided if implicitly set and being set to something different.

PR checklist

"closes #0000" is in the body of the PR description tolink the related issue
new and changed code istested
Plotting related features are demonstrated in anexample
New Features andAPI Changes are noted with adirective and release note
Documentation complies withgeneral anddocstring guidelines

Add explicit converter setting to Axis

12f4078

Closesmatplotlib#19229

github-actionsbot added the topic: ticks axis labels label

Oct 11, 2024

timhoffm reviewed

Oct 11, 2024

View reviewed changes

lib/matplotlib/axis.py OutdatedShow resolvedHide resolved

lib/matplotlib/axis.pyShow resolvedHide resolved

Copy link

Member

jklymak commentedOct 11, 2024

Does this also need aget_converter?

Review comments

4bb8c8d

timhoffm approved these changes

Oct 30, 2024

View reviewed changes

lib/matplotlib/axis.py OutdatedShow resolvedHide resolved

tacaswell added this to thev3.10.0 milestone

Oct 30, 2024

github-actionsbot added the GUI: Qt label

Oct 31, 2024

ksunden commented

Oct 31, 2024

View reviewed changes

lib/matplotlib/backends/qt_editor/figureoptions.py

Comment on lines +212 to 213

		axis._set_converter(axis_converter[name])
		axis.set_units(axis_units[name])

Copy link

MemberAuthor

ksundenOct 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The choice to use the private setter was a defensive one as the public
setter prevents being called multiple times (though does short circuit
if an identical input is provided, which I think is actually true here,
therefore the public one is probably functional (and a no-op).)

It is not clear to me on analysis how the unit information is or was
lost. A quick test commenting out these two lines which reset
converter/units displayed no obvious detrimental effect to removing
them, suggesting that even if once they were necessary, they may no
longer be.

These lines were last touched in#24141, though that really only generalized
the code into a loop rather than copy/pasted x and y behavior.
The original inclusion of resetting was in#4909, which indicated that
the dialog reset unit info. AFAICT, that is no longer true, though I
have not rigorously proved that.

Privatize axis.converter attribute

493fbc6

The replacement is the get/set_converter method.This includes changes to use the getter and the private setter in the qtfigure options dialog menu.The choice to use the private setter was a defensive one as the publicsetter prevents being called multiple times (though does short circuitif an identical input is provided, which I think is actually true here,therefore the public one is probably functional (and a no-op).)It is not clear to me on analysis how the unit information is or waslost. A quick test commenting out the two lines which resetconverter/units displayed no obvious detrimental effect to removingthose, suggesting that even if once they were necessary, they may nolonger be.These lines were last touched inmatplotlib#24141, though that really only generalizedthe code into a loop rather than copy/pasted x and y behavior.The original inclusion of resetting was inmatplotlib#4909, which indicated thatthe dialog reset unit info. AFAICT, that is no longer true, though Ihave not rigorously proved that.