Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Fix MSVC cast warnings#28967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Fix MSVC cast warnings#28967
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
I see one more on AppVeyor to fix: |
These were silently truncated to int anyway, so we should make the typesexplicit.
The Agg API uses `double`s here, but the array sizes are`pybind11::ssize_t`, which are technically bigger (in some ways), andcause a warning on MSVC. We don't accept a backing surface larger than~2^24, so there's no worry about these overflowing.
Its only use was removed in193e5a9.
These were silently truncated to int anyway, so we should make the typesexplicit.
AppVeyor and Azure Windows builds are now warning free. |
tacaswell approved these changesOct 25, 2024
ianthomas23 approved these changesOct 25, 2024
3770dfe intomatplotlib:main 65 of 66 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
MSVC on the Azure/AppVeyor builds currently produce a few warnings. These are due to some lax input types, or otherwise because of differing type sizes on Windows. The values are generally not in the range where it would matter, so we can make the casts explicit to silence the warnings.
For the incorrect types, the old types are deprecated, but still accepted.
This is based on#28842 at the moment due to conflicting changes, but the last four commits are the relevant ones here.
PR checklist