Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
TST: handle change in pytest.importorskip behavior#28925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
It now warns if the module is found, but fails to import (rather thannot existing and raising ModuleNotFound).
Apparently, Azure updated from macOS 12 to 14, which caused the changein results outside of the Intel->ARM change.
Since#28923 didn't yet work, I've pushed an update to the tolerance here. |
timhoffm approved these changesOct 7, 2024
df1e039 intomatplotlib:main 43 checks passed
Uh oh!
There was an error while loading.Please reload this page.
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestOct 7, 2024
QuLogic pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestOct 18, 2024
QuLogic added a commit that referenced this pull requestOct 18, 2024
…925-on-v3.9.xBackport PR#28925 on branch v3.9.x (TST: handle change in pytest.importorskip behavior)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It now warns if the module is found, but fails to import (rather than not existing and raising ModuleNotFound).