Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

ENH/TST: add deadband to image comparison#28923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
tacaswell wants to merge1 commit intomatplotlib:main
base:main
Choose a base branch
Loading
fromtacaswell:tst/add_image_compare_deadband

Conversation

tacaswell
Copy link
Member

This allows us to ignore small images in colors using a more precise threshold than tol provides.

This is motivated due to a new set of semi-random failures on OSX on azure. A simpler fix may be to usetol like we have in many other cases and defer this to 3.11.

PR checklist

@tacaswelltacaswell added this to thev3.11.0 milestoneOct 2, 2024
@tacaswelltacaswell modified the milestones:v3.11.0,v3.10.0Oct 2, 2024
This allows us to ignore small images in colors using a more precisethreshold than tol provides.
@tacaswelltacaswellforce-pushed thetst/add_image_compare_deadband branch from9aed127 tocc5e65eCompareOctober 2, 2024 20:36
@QuLogic
Copy link
Member

It doesn't look like this fixed thetest_axes3d_primary_views failure. Also note that we'll have to fix this on thev3.9.x branch too, so we might just have to bump the tolerance on that one.

@scottshambaugh
Copy link
Contributor

This is a very welcome change. In the 3D plots especially there can be miniscule rendering differences between different platforms which are unrelated to code diffs and are extremely difficult to debug and get tests passing. Only real way I've found is to continuously push up to CI, wait 20 min for tests to run through, then download the image diffs on the failed platforms and enhance contrast in an image editing program (because the diff looks black initially since the diff is so small). Then invariably the fix is to tweak the test slightly and hope the rendering comes out the same. I've gone 10+ cycles of this workflow on some PRs.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Projects
None yet
Milestone
v3.11.0
Development

Successfully merging this pull request may close these issues.

3 participants
@tacaswell@QuLogic@scottshambaugh

[8]ページ先頭

©2009-2025 Movatter.jp