Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
ENH/TST: add deadband to image comparison#28923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This allows us to ignore small images in colors using a more precisethreshold than tol provides.
9aed127
tocc5e65e
CompareIt doesn't look like this fixed the |
This is a very welcome change. In the 3D plots especially there can be miniscule rendering differences between different platforms which are unrelated to code diffs and are extremely difficult to debug and get tests passing. Only real way I've found is to continuously push up to CI, wait 20 min for tests to run through, then download the image diffs on the failed platforms and enhance contrast in an image editing program (because the diff looks black initially since the diff is so small). Then invariably the fix is to tweak the test slightly and hope the rendering comes out the same. I've gone 10+ cycles of this workflow on some PRs. |
This allows us to ignore small images in colors using a more precise threshold than tol provides.
This is motivated due to a new set of semi-random failures on OSX on azure. A simpler fix may be to use
tol
like we have in many other cases and defer this to 3.11.PR checklist