Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

ci: Bump build image on AppVeyor to MSVC 2019#28869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ksunden merged 2 commits intomatplotlib:mainfromQuLogic:msvc-appveyor
Oct 2, 2024

Conversation

QuLogic
Copy link
Member

PR summary

According to the SciPy toolchain roadmap [1], we should be supporting at minimum MSVC 2019. The AppVeyor image has been held back to MSVC 2017 (probably just forgotten since it didn't complain), which is starting to cause issues for more modern code. (Namely#28842 does not work even with the flag for new behaviour.)

There are manyother software changes, so I'm opening this separately from#28842 just to confirm it doesn't break anything.

[1]https://docs.scipy.org/doc/scipy/dev/toolchain.html

PR checklist

@QuLogicQuLogic added CI: testingCI configuration and testing OS: Microsoft labelsSep 24, 2024
@QuLogicQuLogic mentioned this pull requestSep 24, 2024
3 tasks
@QuLogicQuLogic added this to thev3.10.0 milestoneSep 24, 2024
@QuLogicQuLogicforce-pushed themsvc-appveyor branch 2 times, most recently from3af4f8d toa2c9dbcCompareSeptember 26, 2024 02:59
@QuLogic
Copy link
MemberAuthor

Also note that we usewindows-latest for the wheels, which is currentlyWindows Server 2022, andwindows-2019 for tests on Azure.

Unfortunately, micromamba 2.0.0 seems to have been released in the last day, which broke something. I've openedmamba-org/mamba#3467 with some debug information.

@QuLogicQuLogicforce-pushed themsvc-appveyor branch 5 times, most recently from103be01 toaeeea07CompareSeptember 30, 2024 22:36
@QuLogic
Copy link
MemberAuthor

I pinned the micromamba version here, so now AppVeyor is running tests, though it looks like there might be some new failures.

According to the SciPy toolchain roadmap [1], we should be supporting atminimum MSVC 2019. The AppVeyor image has been held back to MSVC 2017(probably just forgotten since it didn't complain), which is starting tocause issues for more modern code.[1]https://docs.scipy.org/doc/scipy/dev/toolchain.html
Version 2 appears to be broken WRT installing PyPI packages:mamba-org/mamba#3467
@QuLogic
Copy link
MemberAuthor

I've pinned wxWidgets as well, which broke wxPython:conda-forge/wxpython-feedstock#125 and now we are building.

timhoffm reacted with hooray emoji

@QuLogic
Copy link
MemberAuthor

QuLogic commentedOct 2, 2024
edited
Loading

Both projects say they have fixed their issues upstream, so I'm going to see if we can revert those.

Edit: It looks like micromamba made their release, but haven't updated their "latest" link yet. So I've left the pin for now.

@ksundenksunden merged commitcf84d9a intomatplotlib:mainOct 2, 2024
39 of 43 checks passed
@QuLogicQuLogic deleted the msvc-appveyor branchOctober 2, 2024 20:29
kyracho pushed a commit to kyracho/matplotlib that referenced this pull requestOct 10, 2024
* ci: Bump build image on AppVeyor to MSVC 2019According to the SciPy toolchain roadmap [1], we should be supporting atminimum MSVC 2019. The AppVeyor image has been held back to MSVC 2017(probably just forgotten since it didn't complain), which is starting tocause issues for more modern code.[1]https://docs.scipy.org/doc/scipy/dev/toolchain.html* ci: Pin micromamba on AppVeyor to v1Version 2 appears to be broken WRT installing PyPI packages:mamba-org/mamba#3467
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ksundenksundenksunden approved these changes

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Labels
CI: testingCI configuration and testingOS: Microsoft
Projects
None yet
Milestone
v3.10.0
Development

Successfully merging this pull request may close these issues.

3 participants
@QuLogic@ksunden@timhoffm

[8]ページ先頭

©2009-2025 Movatter.jp