Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

DOC: Fix non-working code object references#28825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
QuLogic merged 1 commit intomatplotlib:mainfromtimhoffm:doc-fix
Sep 24, 2024

Conversation

timhoffm
Copy link
Member

@timhoffmtimhoffm commentedSep 16, 2024•
edited
Loading

These were not rendered as links in the current docs, because the
associated code objects do not exist as targets in the docs. For some
reason, sphinx did not complain about it. But it does in some recent
PRs (extracted from#28560) - I'm unclear why, but anyway the correct
solution is to change to explicitly listing the attributes.

@timhoffm
Copy link
MemberAuthor

Note: Failing OSX and free-threaded tests are an unrealted CI issue.

@timhoffmtimhoffm marked this pull request as draftSeptember 16, 2024 16:41
@github-actionsgithub-actionsbot added the Documentation: APIfiles in lib/ and doc/api labelSep 17, 2024
@timhoffmtimhoffm marked this pull request as ready for reviewSeptember 17, 2024 07:03
@QuLogic
Copy link
Member

There's an exception forAxes.dataLim indoc/missing-references.json; can that be removed now?

timhoffm reacted with thumbs up emoji

These were not rendered as links in the current docs, because theassociated code objects do not exist as targets in the docs. For somereason, sphinx did not complain about it. But it does in some recentPRs (extracted frommatplotlib#28560) - I'm unclear why, but anyway the correctsolution is to change to explicitly listing the attributes.
Comment on lines +554 to +555
dataLim: mtransforms.Bbox
"""The bounding `.Bbox` enclosing all data displayed in the Axes."""
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We need a place to put the docstring. IMHO a class-level annotation is the best location (though we normally don't write types in the py files).

@QuLogicQuLogic merged commit613c9c9 intomatplotlib:mainSep 24, 2024
40 of 43 checks passed
@lumberbot-appLumberbot (App)
Copy link

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v3.9.xgit pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 613c9c996c20e034de67126e3e1cc42d19835b1f
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #28825: DOC: Fix non-working code object references'
  1. Push to a named branch:
git push YOURFORK v3.9.x:auto-backport-of-pr-28825-on-v3.9.x
  1. Create a PR against branch v3.9.x, I would have named this PR:

"Backport PR#28825 on branch v3.9.x (DOC: Fix non-working code object references)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove theStill Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free tosuggest an improvement.

@timhoffm
Copy link
MemberAuthor

Let's not bother with a manual backport since 3.10 is not that far away.

@timhoffmtimhoffm modified the milestones:v3.9.3,v3.10.0Sep 24, 2024
@timhoffmtimhoffm deleted the doc-fix branchSeptember 24, 2024 10:26
timhoffm added a commit to timhoffm/matplotlib that referenced this pull requestSep 25, 2024
timhoffm added a commit to timhoffm/matplotlib that referenced this pull requestSep 25, 2024
timhoffm added a commit to timhoffm/matplotlib that referenced this pull requestSep 25, 2024
timhoffm added a commit to timhoffm/matplotlib that referenced this pull requestSep 25, 2024
kyracho pushed a commit to kyracho/matplotlib that referenced this pull requestOct 10, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@QuLogicQuLogicQuLogic approved these changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
v3.10.0
Development

Successfully merging this pull request may close these issues.

2 participants
@timhoffm@QuLogic
[8]ページ先頭
©2009-2025 Movatter.jp