Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

DOC: Document policy on colormaps and styles#28815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
story645 merged 1 commit intomatplotlib:mainfromtimhoffm:doc-new-colormaps
Sep 17, 2024

Conversation

timhoffm
Copy link
Member

@timhoffmtimhoffm commentedSep 13, 2024•
edited
Loading

Alsocloses#27673 by removing that page. The relevant content is transferred to the new section.

Note: no backport necessary as we always use the devdocs version for/doc/devel.

@github-actionsgithub-actionsbot added the Documentation: devdocsfiles in doc/devel labelSep 13, 2024
@timhoffmtimhoffm added this to thev3.10.0 milestoneSep 13, 2024
Copy link
Member

@QuLogicQuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

To fixrstcheck and other styling bugs.

Copy link
Member

@story645story645 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@timhoffmtimhoffmforce-pushed thedoc-new-colormaps branch 2 times, most recently frome36b3c2 to2763352CompareSeptember 16, 2024 10:24
Comment on lines 43 to 44
- novelty: Does it support a new use case? e.g. slight variations of existing maps,
sequences and styles or yet "another divergent colormap" are likely not accepted
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
- novelty: Does it support a new use case? e.g. slight variations of existing maps,
sequences and styles or yet "another divergent colormap" are likely not accepted
- novelty: Does it support a new use case? e.g. slight variations of existing maps, including divergent colormaps that are just a new combination of three colors, sequences and styles are likely not accepted

Just tweaking b/c original wording sounded a bit insider baseball (maintainers annoyance) to me

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I've left out the "diverging colormaps" part. Stuffing it into the enumeration "maps, sequences, and styles" distracts the flow of the sentence too much. And also, we can leave it on the abstract level of slight variations without going into examples.

story645 reacted with thumbs up emoji
Alsoclosesmatplotlib#27673 by removing that page. The relevantcontent is transferred to the new section.Co-authored-by: hannah <story645@gmail.com>
@story645story645 merged commitc56c404 intomatplotlib:mainSep 17, 2024
26 checks passed
@timhoffmtimhoffm deleted the doc-new-colormaps branchSeptember 17, 2024 15:18
@jklymak
Copy link
Member

This only had one approval for a policy documentation. Maybe this should have more time for discussion before becoming the defacto "policy"?

@timhoffm
Copy link
MemberAuthor

I see this as rough guidelines rather than a fixed policy. But feel free to make a follow up issue or PR.

@jklymak
Copy link
Member

I'm fine with it. Just if we are calling it a policy it may be good to have more time for discussion.

@story645
Copy link
Member

I strongly encourage using the "needs discussion" label for things anyone feels need more time for discussion.

But also I saw this as writing up the things we've informally been telling folks for ages, and that Tim had addressed all the review comments so figured there was consensus?

@jklymak
Copy link
Member

Not a big deal - just think that, in the future, if something is going to be a "policy" we should have two sign-offs versus one.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@QuLogicQuLogicQuLogic left review comments

@jklymakjklymakjklymak left review comments

@story645story645story645 approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.10.0
Development

Successfully merging this pull request may close these issues.

[Doc]: Confusing page on color changes
4 participants
@timhoffm@jklymak@story645@QuLogic
[8]ページ先頭
©2009-2025 Movatter.jp