Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
patheffects.SimpleLineShadow calling non-existent get_foreground method from GraphicsContextBase#28814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join uson gitter for real-time discussion.
For details on testing, writing docs, and our review process, please seethe developer guide
We strive to be a welcoming and open project. Please follow ourCode of Conduct.
@timhoffm Hi. Just wondering what else needs to get done before this fix can get merged. |
Per our merge policy, we need two reviews. So this is waiting for a second core developer to approve. |
Are you interested in writing a test? It looks like you have a test script in#28793, and it should be able to be turned into afigure comparison if you compare the path effect with directly plotting a line with the effective settings. |
Sure, that shouldn't be a problem |
I don't understand; the point of the test would be to confirm that the shadow is set the way you'd expect it to, and thus have equal figures. |
I see what you mean. I changed it to plot a line with the alpha value instead for transparency. |
Uh oh!
There was an error while loading.Please reload this page.
resolves#28793 : Replaced nonexistent get_foreground() method with get_rgb()
PR checklist