Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

patheffects.SimpleLineShadow calling non-existent get_foreground method from GraphicsContextBase#28814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
anijjar wants to merge6 commits intomatplotlib:main
base:main
Choose a base branch
Loading
fromanijjar:bug/28793

Conversation

anijjar
Copy link
Contributor

@anijjaranijjar commentedSep 13, 2024
edited
Loading

resolves#28793 : Replaced nonexistent get_foreground() method with get_rgb()


PR checklist

Copy link

@github-actionsgithub-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join uson gitter for real-time discussion.

For details on testing, writing docs, and our review process, please seethe developer guide

We strive to be a welcoming and open project. Please follow ourCode of Conduct.

@anijjaranijjar reopened thisSep 16, 2024
@anijjar
Copy link
ContributorAuthor

@timhoffm Hi. Just wondering what else needs to get done before this fix can get merged.

@timhoffm
Copy link
Member

Per our merge policy, we need two reviews. So this is waiting for a second core developer to approve.

anijjar reacted with thumbs up emoji

@QuLogic
Copy link
Member

Are you interested in writing a test? It looks like you have a test script in#28793, and it should be able to be turned into afigure comparison if you compare the path effect with directly plotting a line with the effective settings.

@anijjar
Copy link
ContributorAuthor

Are you interested in writing a test? It looks like you have a test script in#28793, and it should be able to be turned into afigure comparison if you compare the path effect with directly plotting a line with the effective settings.

Sure, that shouldn't be a problem

@anijjar
Copy link
ContributorAuthor

I marked the test as XFail because the '@check_figures_equal()' decorator only works for identical results. Here are screen captures of the diff.
test_simpleLineShadow_plot pdf _pdf
test_simpleLineShadow_plot pdf _pdf-failed-diff
test_simpleLineShadow_plot pdf -expected_pdf

@QuLogic
Copy link
Member

I don't understand; the point of the test would be to confirm that the shadow is set the way you'd expect it to, and thus have equal figures.

@anijjar
Copy link
ContributorAuthor

I don't understand; the point of the test would be to confirm that the shadow is set the way you'd expect it to, and thus have equal figures.

I see what you mean. I changed it to plot a line with the alpha value instead for transparency.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Projects
Status: Needs review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

patheffects.SimpleLineShadow calling non-existentget_foreground method from GraphicsContextBase
3 participants
@anijjar@timhoffm@QuLogic

[8]ページ先頭

©2009-2025 Movatter.jp