Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
ENH: fig.annotate#28753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
ENH: fig.annotate#28753
Uh oh!
There was an error while loading.Please reload this page.
Conversation
See also#25998. |
@anntzer yes I agree we should add a fig.annotate method. Also this is lightweight enough that we should document how this works b/c I find the artist API just a bit intimidating. |
…w textsCo-authored-by: Thomas A Caswell <tcaswell@gmail.com>
also is the linting check running off main and so won't see this exception? |
Artist instantiation + add_artist should not be a first-class user-facing API. The standard pattern in matplotlib are functions to create the artists. I'd be very reluctant to dilute this. Frist and foremost I consider add_artist a low level API, that end-users should not have to use. It should be the very exception in examples and only show up in corner cases for which it is not worth having high-level API. If advertised in such a scenario, we should communicate that we use low-level API. |
story645 commentedAug 25, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
So is that a second yes for@anntzer's proposal of a figure.annotate? As far as I can tell, the implementation is basically forward to artist + add artist to figure & if so I'll just update this PR to do that and then update these docs to show that. I just wanted to document how you get figure level rainbow text and annotation b/c folks request it and I've needed at least the rainbow text a few times. |
Consensus on the call this week was to add |
Uh oh!
There was an error while loading.Please reload this page.
PR summary
Based ongitter convo w/@tacaswell, the
text.Annotation
object is a really simple way to make rainbow figure text, so:PR checklist